Skip to content

Conversation

@Trott
Copy link
Member

@TrottTrott commented Oct 8, 2020

  • add kbd elements
  • correct period/parenthesis order
  • make fragment a full sentence
Checklist

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core. labels Oct 8, 2020
@Trott
Copy link
MemberAuthor

Trott commented Oct 8, 2020

Before:

image

After:

image

* add kbd elements * correct period/parenthesis order * make fragment a full sentence PR-URL: nodejs#35558 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
@TrottTrott merged commit 91f0544 into nodejs:masterOct 10, 2020
@Trott
Copy link
MemberAuthor

Landed in 91f0544

@TrottTrott deleted the sigint branch October 10, 2020 12:17
MylesBorins pushed a commit that referenced this pull request Oct 14, 2020
* add kbd elements * correct period/parenthesis order * make fragment a full sentence PR-URL: #35558 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Oct 14, 2020
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
* add kbd elements * correct period/parenthesis order * make fragment a full sentence PR-URL: #35558 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Nov 3, 2020
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
* add kbd elements * correct period/parenthesis order * make fragment a full sentence PR-URL: #35558 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
* add kbd elements * correct period/parenthesis order * make fragment a full sentence PR-URL: nodejs#35558 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.errorsIssues and PRs related to JavaScript errors originated in Node.js core.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Trott@addaleax@Flarna@nodejs-github-bot