Skip to content

Conversation

@aduh95
Copy link
Contributor

Refs: #35206

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 11, 2020
@aduh95aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 11, 2020
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 11, 2020
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

Refs: nodejs#35206 PR-URL: nodejs#35599 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@TrottTrottforce-pushed the fix-cq-failure-comment branch from 185818d to ac5df63CompareOctober 14, 2020 13:12
@Trott
Copy link
Member

Landed in ac5df63

@TrottTrott merged commit ac5df63 into nodejs:masterOct 14, 2020
@aduh95aduh95 deleted the fix-cq-failure-comment branch October 14, 2020 13:16
MylesBorins pushed a commit that referenced this pull request Oct 14, 2020
Refs: #35206 PR-URL: #35599 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Oct 14, 2020
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
Refs: nodejs#35206 PR-URL: nodejs#35599 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

toolsIssues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@aduh95@nodejs-github-bot@Trott@lundibundi