build: do not pass mode option to test-v8 command#35705
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
It was removed upstream and is now inferred from the build config.
nodejs-github-bot added the build 
MemberAuthor
targos commented Oct 19, 2020
Please 👍 to fast-track. V8 CI is broken without this change. |
targos added dont-land-on-v10.x fast-track 
richardlau approved these changes Oct 19, 2020
Collaborator
Member
richardlau commented Oct 19, 2020
cc @BethGriggs This affects the 15.0.0-proposal. |
gengjiawen approved these changes Oct 19, 2020
BethGriggs approved these changes Oct 19, 2020
codecov-io commented Oct 19, 2020
Codecov Report
@@ Coverage Diff @@## master #35705 +/- ## ======================================= Coverage 96.40% 96.40% ======================================= Files 220 220 Lines 73681 73681 ======================================= + Hits 71031 71033 +2 + Misses 2650 2648 -2
Continue to review full report at Codecov.
|
watilde approved these changes Oct 19, 2020
Collaborator
nodejs-github-bot commented Oct 19, 2020
Trott approved these changes Oct 19, 2020
gengjiawen pushed a commit that referenced this pull request Oct 19, 2020
It was removed upstream and is now inferred from the build config. PR-URL: #35705 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Member
gengjiawen commented Oct 19, 2020
Landed in b18651b |
targos added a commit to targos/node that referenced this pull request Apr 20, 2021
It was removed upstream and is now inferred from the build config. PR-URL: nodejs#35705 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos added a commit to targos/node that referenced this pull request Apr 27, 2021
It was removed upstream and is now inferred from the build config. PR-URL: nodejs#35705 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos added a commit that referenced this pull request Apr 30, 2021
It was removed upstream and is now inferred from the build config. PR-URL: #35705 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]> PR-URL: #38275 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Jun 23, 2021
V8's test-runner dropped the `--mode` argument some time back, and now produces the following error if run with it: run-tests.py: error: no such option: --mode PR-URL: #39055 Refs: #35705 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Jul 11, 2021
V8's test-runner dropped the `--mode` argument some time back, and now produces the following error if run with it: run-tests.py: error: no such option: --mode PR-URL: #39055 Refs: #35705 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Sep 4, 2021
V8's test-runner dropped the `--mode` argument some time back, and now produces the following error if run with it: run-tests.py: error: no such option: --mode PR-URL: #39055 Refs: #35705 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was removed upstream and is now inferred from the build config.
Refs: nodejs/node-v8#180 (comment)