doc: made code spans more visible#3573
Uh oh!
There was an error while loading. Please reload this page.
Conversation
evanlucas commented Oct 29, 2015
LGTM |
doc/api_assets/style.css Outdated
There was a problem hiding this comment.
I think a padding of 0.2em 0.4em would look better visually, it's what GitHub does too (They do it through a unicode space in :before and :after) to make the left and right padding slightly larger.
jasnell commented Oct 29, 2015
LGTM |
phillipjforce-pushed the doc-code-visibility branch from cca141e to ef2e668Comparephillipj commented Oct 29, 2015
@silverwind agreed, just updated with a little extra horizontal padding.
|
silverwind commented Oct 29, 2015
LGTM One thing that bugs me a bit is that |
This makes the code spans in the API docs more visible and therefore readable by adding some background color. PR-URL: #3573 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
silverwind commented Oct 29, 2015
Thanks. Landed in d995b72. |
phillipj commented Nov 4, 2015
Any chance this could be backported to |
jasnell commented Nov 4, 2015
There shouldn't be any problem getting this in to v4 :-) |
This makes the code spans in the API docs more visible and therefore readable by adding some background color. PR-URL: #3573 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
This makes the code spans in the API docs more visible and therefore readable by adding some background color. PR-URL: #3573 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
MylesBorins commented Nov 16, 2015
landed in lts-v4.x-staging as 08ab9f3 |
MylesBorins commented Nov 16, 2015
@silverwind does this need a land-on-v5.x tag if it is on master? |
silverwind commented Nov 16, 2015
@thealphanerd No, that tag was unnecessary ;) |
MylesBorins commented Nov 16, 2015
phillipj commented Nov 17, 2015
Thanks @thealphanerd! |
This makes the code spans in the API docs more visible and therefore readable by adding some background color. PR-URL: #3573 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
This makes the code spans in the API docs more visible and therefore readable by adding some background color. PR-URL: #3573 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
This makes the code spans in the API docs more visible and therefore readable by adding some background color. PR-URL: #3573 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
6 participants
This makes the code spans in the API docs alot more visible and therefore readable by adding some background color. Its more or less what github.com does, and what we decided to do on nodejs.org with nodejs/nodejs.org#146.
Closes an issue raised about API docs readability in nodejs/nodejs.org#121.