doc: fix a typo in CHANGELOG_V15#35804
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
fhinkel approved these changes Oct 26, 2020
aduh95 approved these changes Oct 26, 2020
watilde approved these changes Oct 26, 2020
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Oct 26, 2020
Member
Trott commented Oct 26, 2020
Since the typo is in the commit message, this will mean that the change log will be different from the commit log. In the past, we've opted to leave typographical errors unfixed in the change log if the error is derived from commit messages via tooling, like this one. See, for example, #20716 (comment). (I don't have strong feelings either way. I'm fine with fixing them and I'm fine with leaving them alone.) |
Trott approved these changes Oct 26, 2020
gireeshpunathil approved these changes Oct 26, 2020
Signed-off-by: Takuya Noguchi <[email protected]> PR-URL: nodejs#35804 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
Member
Trott commented Oct 30, 2020
Landed in 02e60a6 Thanks for the contribution! 🎉 |
targos pushed a commit that referenced this pull request Nov 3, 2020
Signed-off-by: Takuya Noguchi <[email protected]> PR-URL: #35804 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a typo around #32984.
Checklist