build: do not run GitHub actions for draft PRs#35910
Uh oh!
There was an error while loading. Please reload this page.
Conversation
nodejs-github-bot added the meta 
targos commented Nov 1, 2020
So, the condition works. Jobs were skipped: |
targos commented Nov 1, 2020
Marking the PR a s ready is not enough to re-run the workflows. |
targos commented Nov 1, 2020
Apparently GitHub thinks I'm from the future 😄 |
gengjiawen commented Nov 1, 2020
When we mark it as ready, will it trigger github action run ? |
Trott commented Nov 1, 2020
No, but I think we can manually run the jobs (and GitHub Actions are advisory in most cases anyway), so I'm OK with this behavior. I'm going to try to manually kick off the jobs to confirm that's possible. Hopefully I'm not messing up @targos's experiment.... |
Trott commented Nov 1, 2020
Argh, nope, it skips them still. I guess we'd have to kick off Jenkins for any PR opened as Draft? I'm still OK with that, although there are jobs in GitHub Actions (ASAN, tarball building, coverage, codeowners assignment, maybe others) that don't get run in Jenkins..... so it's less ideal, for sure.... |
Trott commented Nov 1, 2020
Hmmm... just in case the not-able-to-run-once-out-of-draft-mode stuff is all due to some daylight-savings-in-North-America weirdness, I'm going to put it into Draft mode again, and then take it out again.... |
Trott commented Nov 1, 2020
Maybe pushing (or force-pushing) will be enough to kick off the jobs? |
Trott commented Nov 1, 2020
Rebasing against master and force-pushing to see if that kicks off the jobs. |
Trott commented Nov 1, 2020
That seems to have worked. I can live with that. |
gengjiawen commented Nov 1, 2020
Works with me too. Can this be integrated with our CI robot ? |
jasnell commented Dec 16, 2020
Needs a rebase before this can land |
targosforce-pushed the no-draft-workflow branch from ac10fb9 to 25b92b0Compare
targosforce-pushed the no-draft-workflow branch from 25b92b0 to 363d4e4ComparePR-URL: #35910Fixes: #35899 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
targos commented Dec 21, 2020
Landed in aadb0bd |
PR-URL: #35910Fixes: #35899 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
9 participants
Closes: #35899
I also pushed another branch just to verify that this doesn't prevent branch pushes to execute the workflow: https://github.com/nodejs/node/commits/no-draft-workflow-with-branch
Opened as a draft this time.