stream: remove isPromise utility function#35925
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Nov 2, 2020
Review requested:
|
ronag requested changes Nov 2, 2020
ContributorAuthor
aduh95 commented Nov 2, 2020
Yes the behavior is the same. Another way would be to change the name of the function |
Member
benjamingr commented Nov 2, 2020
Actually the current implementation (and the one in this PR) is wrong if someone passes a It's not a big bug but promise test suites check for it. The correct implementation would be to do it in "two steps":
See here for an example |
ronag added a commit to nodejs/undici that referenced this pull request Nov 2, 2020
The function was not checking if the parameter was actually a Promise instance, but if it has a `then` method. Removing the utility function in favor of a clearer `typeof` check, handling the case when the thenable throws if then method is accessed more than once.
aduh95force-pushed the stream-remove-isPromise branch from 35e4d0a to f18db47CompareContributorAuthor
aduh95 commented Nov 2, 2020
I've implemented the solution suggested by @benjamingr, PTAL. |
benjamingr approved these changes Nov 2, 2020
Member
benjamingr left a comment
benjamingr left a comment There was a problem hiding this comment.
Please consider adding a test.
If you prefer not to - I'll add one sometime after this lands :]
ContributorAuthor
aduh95 commented Nov 3, 2020
Test added! It does fail on master and not with this PR, PTAL. @ronag Have your concerns been addressed? |
ContributorAuthor
aduh95 commented Nov 8, 2020
@ronag are you still blocking this or can your objection be dismissed? |
github-actionsbot removed the request-ci This comment has been minimized.
This comment has been minimized.
ronag approved these changes Nov 8, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
nodejs-github-bot commented Nov 9, 2020
mcollina added the commit-queue github-actionsbot removed the commit-queue 
Contributor
Landed in adae822...ad98cf0 |
nodejs-github-bot pushed a commit that referenced this pull request Nov 9, 2020
The function was not checking if the parameter was actually a Promise instance, but if it has a `then` method. Removing the utility function in favor of a clearer `typeof` check, handling the case when the thenable throws if then method is accessed more than once. PR-URL: #35925 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
danielleadams pushed a commit that referenced this pull request Nov 9, 2020
The function was not checking if the parameter was actually a Promise instance, but if it has a `then` method. Removing the utility function in favor of a clearer `typeof` check, handling the case when the thenable throws if then method is accessed more than once. PR-URL: #35925 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Merged
targos pushed a commit that referenced this pull request May 1, 2021
The function was not checking if the parameter was actually a Promise instance, but if it has a `then` method. Removing the utility function in favor of a clearer `typeof` check, handling the case when the thenable throws if then method is accessed more than once. PR-URL: #35925 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function was not checking if the parameter was actually a Promise
instance, but if it has a
thenmethod. Removing the utility functionin favor of a clearer
typeofcheck, handling the case when thethenable throws if then method is accessed more than once.
The difference between a thenable and a
Promisemay be important when using third party library (the parameter is provided by the user) and/or whenPromise.prototype.thenvalue is changed from userland.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes