Skip to content

tools: update ESLint to 7.13.0#36031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lpinca wants to merge 1 commit into from
Closed

tools: update ESLint to 7.13.0 #36031

lpinca wants to merge 1 commit into from

Conversation

@lpinca
Copy link
Member

@lpincalpinca commented Nov 8, 2020

Update ESLint to 7.13.0

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@lpinca
tools: update ESLint to 7.13.0
6b68143
Update ESLint to 7.13.0
@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Nov 8, 2020
aduh95
aduh95 approved these changes Nov 8, 2020
View reviewed changes
Copy link
Contributor

@aduh95aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 8, 2020
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 8, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 9, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@aduh95aduh95 removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 9, 2020
trivikr
trivikr approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@trivikrtrivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 10, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 10, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/34303/

@github-actionsgithub-actionsbot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 11, 2020
@github-actions
Copy link
Contributor

github-actionsbot commented Nov 11, 2020

Landed in 7cba786...39a7f76

nodejs-github-bot pushed a commit that referenced this pull request Nov 11, 2020
@lpinca@nodejs-github-bot
tools: update ESLint to 7.13.0
39a7f76
Update ESLint to 7.13.0 PR-URL: #36031 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@lpincalpinca deleted the update/eslint-to-7.13.0 branch November 11, 2020 06:04
codebytere pushed a commit that referenced this pull request Nov 22, 2020
@lpinca@codebytere
tools: update ESLint to 7.13.0
be220b2
Update ESLint to 7.13.0 PR-URL: #36031 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@codebyterecodebytere mentioned this pull request Nov 22, 2020
Merged
targos pushed a commit that referenced this pull request May 16, 2021
@lpinca@targos
tools: update ESLint to 7.13.0
17c8484
Update ESLint to 7.13.0 PR-URL: #36031 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@targostargos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@lpinca@targos
tools: update ESLint to 7.13.0
55fc206
Update ESLint to 7.13.0 PR-URL: #36031 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes

@cjihrigcjihrigcjihrig approved these changes

@aduh95aduh95aduh95 approved these changes

@trivikrtrivikrtrivikr approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lpinca@nodejs-github-bot@Trott@cjihrig@aduh95@trivikr