doc: fix typo in events.getEventListeners example#36085
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added doc 
lpinca approved these changes Nov 11, 2020
benjamingr approved these changes Nov 11, 2020
Member
benjamingr left a comment
benjamingr left a comment There was a problem hiding this comment.
Thanks good catch!
API feedback welcome as well :]
If you want to find more places to contribute - this API could probably use a few more tests as well!
Member
benjamingr commented Nov 11, 2020
As this is a docs typo and a first time contributor: 👍 to fast track |
github-actionsbot removed the request-ci 
This comment has been minimized.
This comment has been minimized.
ZYSzys approved these changes Nov 11, 2020
aduh95 approved these changes Nov 11, 2020
Collaborator
nodejs-github-bot commented Nov 11, 2020
aduh95 added author ready github-actionsbot added commit-queue-failed 
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/36085 ✔ Done loading data for nodejs/node/pull/36085 ----------------------------------- PR info ------------------------------------ Title doc: fix typo in `events.getEventListeners` example (#36085) Author Dmitry Semigradsky (@Semigradsky, first-time contributor) Branch Semigradsky:patch-1 -> nodejs:master Labels author ready, doc, events Commits 1 - doc: fix `events.getEventListeners` example Committers 1 - GitHub PR-URL: https://github.com/nodejs/node/pull/36085 Reviewed-By: Luigi Pinca Reviewed-By: Benjamin Gruenbaum Reviewed-By: Yongsheng Zhang Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/36085 Reviewed-By: Luigi Pinca Reviewed-By: Benjamin Gruenbaum Reviewed-By: Yongsheng Zhang Reviewed-By: Antoine du Hamel -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ℹ Doc-only changes ℹ This PR was created on Wed, 11 Nov 2020 15:54:59 GMT ✔ Approvals: 4 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/36085#pullrequestreview-528307178 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/36085#pullrequestreview-528329331 ✔ - Yongsheng Zhang (@ZYSzys): https://github.com/nodejs/node/pull/36085#pullrequestreview-528351605 ✔ - Antoine du Hamel (@aduh95): https://github.com/nodejs/node/pull/36085#pullrequestreview-528412376 ✖ This PR needs to wait 45 more hours to land -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu Commit Queue action: https://github.com/nodejs/node/actions/runs/358244318 |
aduh95 added commit-queue github-actionsbot removed the commit-queue Contributor
Landed in c0ac692...a8b8b8b |
nodejs-github-bot pushed a commit that referenced this pull request Nov 11, 2020
PR-URL: #36085 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Member
benjamingr commented Nov 11, 2020
Congrats on your first contribution @Semigradsky 🎉 and a personal thanks for fixing my bug! |
targos pushed a commit that referenced this pull request May 1, 2021
PR-URL: #36085 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Merged
Pranay180420 pushed a commit to Pranay180420/Node.jsforme that referenced this pull request Feb 17, 2025
PR-URL: nodejs/node#36085 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes