Skip to content

Conversation

@aduh95
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 18, 2020
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 18, 2020
@nodejs-github-bot
Copy link
Collaborator

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 19, 2020
@github-actionsgithub-actionsbot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 19, 2020
@github-actions
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/36140 ✔ Done loading data for nodejs/node/pull/36140 ----------------------------------- PR info ------------------------------------ Title internal: refactor to use more primordials (#36140) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:main-primordials -> nodejs:master Labels author ready Commits 1 - internal: refactor to use more primordials Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/36140 Reviewed-By: Rich Trott Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/36140 Reviewed-By: Rich Trott Reviewed-By: James M Snell -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2020-11-18T13:54:23Z: https://ci.nodejs.org/job/node-test-pull-request/34452/ - Querying data for job/node-test-pull-request/34452/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Mon, 16 Nov 2020 23:09:37 GMT ✔ Approvals: 2 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36140#pullrequestreview-533395778 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/36140#pullrequestreview-534528748 -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 36140 From https://github.com/nodejs/node * branch refs/pull/36140/merge -> FETCH_HEAD ✔ Fetched commits as 275aa6845ea7..63bbbf57b02a -------------------------------------------------------------------------------- [master f60270928c] internal: refactor to use more primordials Author: Antoine du Hamel Date: Sun Nov 15 19:18:33 2020 +0100 2 files changed, 31 insertions(+), 19 deletions(-) ✔ Patches applied -------------------------------------------------------------------------------- --------------------------------- New Message ---------------------------------- internal: refactor to use more primordials 

PR-URL: #36140
Reviewed-By: Rich Trott [email protected]
Reviewed-By: James M Snell [email protected]

[master bff8f031f7] internal: refactor to use more primordials
Author: Antoine du Hamel [email protected]
Date: Sun Nov 15 19:18:33 2020 +0100
2 files changed, 31 insertions(+), 19 deletions(-)
✖ bff8f031f7d02369a8aaadb823bfe98817f5d6c0
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 1:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✖ 0:0 Invalid subsystem: "internal" subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length

ℹ Please fix the commit message and try again.

https://github.com/nodejs/node/actions/runs/372812416

aduh95 added a commit that referenced this pull request Nov 19, 2020
PR-URL: #36140 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
@aduh95
Copy link
ContributorAuthor

Landed in 3e0194e

@aduh95aduh95 closed this Nov 19, 2020
@aduh95aduh95 deleted the main-primordials branch November 19, 2020 18:19
codebytere pushed a commit that referenced this pull request Nov 22, 2020
PR-URL: #36140 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
@codebyterecodebytere mentioned this pull request Nov 22, 2020
targos pushed a commit that referenced this pull request May 16, 2021
PR-URL: #36140 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
@targostargos mentioned this pull request Jun 6, 2021
targos pushed a commit that referenced this pull request Jun 11, 2021
PR-URL: #36140 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
@targostargos removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 5, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@aduh95@nodejs-github-bot@jasnell@Trott@targos