http2: refactor to use more primordials#36142
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the lib / src 
Collaborator
nodejs-github-bot commented Nov 16, 2020
Review requested:
|
aduh95 added author ready 
github-actionsbot removed the request-ci This comment has been minimized.
This comment has been minimized.
jasnell approved these changes Nov 17, 2020
Collaborator
nodejs-github-bot commented Nov 17, 2020
Qard approved these changes Nov 17, 2020
rickyes approved these changes Nov 18, 2020
Trott approved these changes Nov 19, 2020
aduh95 added the commit-queue github-actionsbot removed the commit-queue 
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/36142 ✔ Done loading data for nodejs/node/pull/36142 ----------------------------------- PR info ------------------------------------ Title http2: refactor to use more primordials (#36142) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:http2-primordials -> nodejs:master Labels author ready, lib / src Commits 1 - http2: refactor to use more primordials Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/36142 Reviewed-By: Matteo Collina Reviewed-By: James M Snell Reviewed-By: Stephen Belanger Reviewed-By: Ricky Zhou <[email protected]> Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/36142 Reviewed-By: Matteo Collina Reviewed-By: James M Snell Reviewed-By: Stephen Belanger Reviewed-By: Ricky Zhou <[email protected]> Reviewed-By: Rich Trott -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2020-11-17T19:17:16Z: https://ci.nodejs.org/job/node-test-pull-request/34442/ - Querying data for job/node-test-pull-request/34442/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Mon, 16 Nov 2020 23:52:24 GMT ✔ Approvals: 5 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/36142#pullrequestreview-532585393 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/36142#pullrequestreview-532647979 ✔ - Stephen Belanger (@Qard): https://github.com/nodejs/node/pull/36142#pullrequestreview-532766517 ✔ - Ricky Zhou (@rickyes): https://github.com/nodejs/node/pull/36142#pullrequestreview-533094527 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36142#pullrequestreview-534396238 ⚠ This PR has conflicts that must be resolved -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/372812416 |
github-actionsbot added the commit-queue-failed aduh95force-pushed the http2-primordials branch from 0a4493b to a6f616bComparegithub-actionsbot removed the request-ci This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
aduh95 added author ready github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Nov 20, 2020
Collaborator
nodejs-github-bot commented Nov 20, 2020
PR-URL: nodejs#36142 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Ricky Zhou <[email protected]> Reviewed-By: Rich Trott <[email protected]>
aduh95force-pushed the http2-primordials branch from db225c3 to 514f464CompareContributorAuthor
aduh95 commented Nov 20, 2020
Landed in 514f464 |
codebytere pushed a commit that referenced this pull request Nov 22, 2020
PR-URL: #36142 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Ricky Zhou <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes