Skip to content

Update url.md#36147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aarock1234 wants to merge 1 commit into from
Closed

Update url.md #36147

aarock1234 wants to merge 1 commit into from

Conversation

@aarock1234
Copy link
Contributor

@aarock1234aarock1234 commented Nov 17, 2020•
edited
Loading

Add missing 's' to example URL.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@aarock1234
Update url.md
10e57b0
Add missing 's' to example URL.
@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module. labels Nov 17, 2020
@jasnelljasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 16, 2020
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 16, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 16, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/34977/

jasnell pushed a commit that referenced this pull request Dec 16, 2020
@aarock1234@jasnell
doc: update url.md
b558075
Add missing 's' to example URL. PR-URL: #36147 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Dec 16, 2020

Landed in b558075

@jasnelljasnell closed this Dec 16, 2020
targos pushed a commit that referenced this pull request Dec 21, 2020
@aarock1234@targos
doc: update url.md
f09985d
Add missing 's' to example URL. PR-URL: #36147 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: James M Snell <[email protected]>
@targostargos mentioned this pull request Dec 22, 2020
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@aarock1234@targos
doc: update url.md
760e593
Add missing 's' to example URL. PR-URL: #36147 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: James M Snell <[email protected]>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@TrottTrottTrott approved these changes

@benjamingrbenjamingrbenjamingr approved these changes

@lpincalpincalpinca approved these changes

@HarshithaKPHarshithaKPHarshithaKP approved these changes

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.urlIssues and PRs related to the legacy built-in url module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@aarock1234@nodejs-github-bot@jasnell@Trott@benjamingr@lpinca@HarshithaKP