lib: remove primordials.SafePromise#36149
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
aduh95 added lib / src 
targos approved these changes Nov 17, 2020
github-actionsbot removed the request-ci 
This comment has been minimized.
This comment has been minimized.
Trott approved these changes Nov 17, 2020
joyeecheung approved these changes Nov 17, 2020
This comment has been minimized.
This comment has been minimized.
Collaborator
nodejs-github-bot commented Nov 17, 2020
lpinca approved these changes Nov 17, 2020
aduh95 added the author ready 
PR-URL: nodejs#36149 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Trottforce-pushed the primordials-SafePromise branch from de2e461 to a46b21fCompare
Member
Trott commented Nov 19, 2020
Landed in a46b21f |
codebytere pushed a commit that referenced this pull request Nov 22, 2020
PR-URL: #36149 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
targos pushed a commit that referenced this pull request May 1, 2021
PR-URL: #36149 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
primordials.SafePromiseis not used in core anymore, andasync/awaitcreates genuinePromiseobjects anyway.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes