Skip to content

Conversation

@aduh95
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Nov 18, 2020
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 19, 2020
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 19, 2020
@nodejs-github-bot
Copy link
Collaborator

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 20, 2020
@github-actionsgithub-actionsbot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 20, 2020
@github-actions
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/36167 ✔ Done loading data for nodejs/node/pull/36167 ----------------------------------- PR info ------------------------------------ Title error: refactor to use more primordials (#36167) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:error-prefer-primordials -> nodejs:master Labels author ready, errors Commits 2 - error: refactor to use more primordials - fixup! error: refactor to use more primordials Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/36167 Reviewed-By: James M Snell Reviewed-By: Trivikram Kamat ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/36167 Reviewed-By: James M Snell Reviewed-By: Trivikram Kamat -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2020-11-19T15:29:46Z: https://ci.nodejs.org/job/node-test-pull-request/34468/ - Querying data for job/node-test-pull-request/34468/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Wed, 18 Nov 2020 19:03:39 GMT ✔ Approvals: 2 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/36167#pullrequestreview-534523144 ✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/36167#pullrequestreview-535143757 -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 36167 From https://github.com/nodejs/node * branch refs/pull/36167/merge -> FETCH_HEAD ✔ Fetched commits as 514f464a600f..86a97e77131b -------------------------------------------------------------------------------- Auto-merging lib/internal/errors.js [master e8aed38623] error: refactor to use more primordials Author: Antoine du Hamel Date: Wed Nov 18 10:57:14 2020 +0100 1 file changed, 5 insertions(+), 3 deletions(-) [master 364cbb53c3] fixup! error: refactor to use more primordials Author: Antoine du Hamel Date: Wed Nov 18 23:04:31 2020 +0100 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/3) Rebasing (3/3) 

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
error: refactor to use more primordials

PR-URL: #36167
Reviewed-By: James M Snell [email protected]
Reviewed-By: Trivikram Kamat [email protected]

[detached HEAD 3040985162] error: refactor to use more primordials
Author: Antoine du Hamel [email protected]
Date: Wed Nov 18 10:57:14 2020 +0100
2 files changed, 6 insertions(+), 4 deletions(-)

Successfully rebased and updated refs/heads/master.
✖ 304098516274403bd25ac48509525904bed24b2b
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 1:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✖ 0:0 Invalid subsystem: "error" subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length

ℹ Please fix the commit message and try again.

https://github.com/nodejs/node/actions/runs/375072234

PR-URL: nodejs#36167 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@aduh95aduh95force-pushed the error-prefer-primordials branch from 86a97e7 to 893d8a6CompareNovember 20, 2020 21:23
@aduh95aduh95 merged commit 893d8a6 into nodejs:masterNov 20, 2020
@aduh95
Copy link
ContributorAuthor

Landed in 893d8a6

@aduh95aduh95 deleted the error-prefer-primordials branch November 20, 2020 21:23
codebytere pushed a commit that referenced this pull request Nov 22, 2020
PR-URL: #36167 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@codebyterecodebytere mentioned this pull request Nov 22, 2020
targos pushed a commit that referenced this pull request May 16, 2021
PR-URL: #36167 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@targostargos mentioned this pull request Jun 6, 2021
targos pushed a commit that referenced this pull request Jun 11, 2021
PR-URL: #36167 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@targostargos removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 5, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.errorsIssues and PRs related to JavaScript errors originated in Node.js core.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@aduh95@nodejs-github-bot@jasnell@trivikr@targos