Skip to content

Conversation

@richardlau
Copy link
Member

Reflect the current status of support for building on arm64 (Apple Silicon/M1) based macOS.

Refs: nodejs/build#2474

cc @nodejs/platform-macos

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Nov 20, 2020
@richardlaurichardlau added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. macos Issues and PRs related to the macOS platform / OSX. labels Nov 20, 2020
Copy link
Member

@mcollinamcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Trott pushed a commit that referenced this pull request Nov 22, 2020
PR-URL: #36189 Refs: nodejs/build#2474 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Pranshu Srivastava <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
@Trott
Copy link
Member

Landed in 62a5626

@TrottTrott closed this Nov 22, 2020
@richardlaurichardlau deleted the building branch November 22, 2020 16:16
codebytere pushed a commit that referenced this pull request Nov 22, 2020
PR-URL: #36189 Refs: nodejs/build#2474 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Pranshu Srivastava <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
@codebyterecodebytere mentioned this pull request Nov 22, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.buildIssues and PRs related to build files or the CI.docIssues and PRs related to the documentations.macosIssues and PRs related to the macOS platform / OSX.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@richardlau@Trott@mcollina@jasnell@targos@devnexen@AshCripps@rexagod@nodejs-github-bot