Skip to content

doc: provide additional context#36201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mhdawson wants to merge 4 commits into from
Closed

doc: provide additional context #36201

mhdawson wants to merge 4 commits into from

Conversation

@mhdawson
Copy link
Member

@mhdawsonmhdawson commented Nov 20, 2020

In the discussion of #35323
it was suggested that we should add some
additional context/clarification.

Signed-off-by: Michael Dawson [email protected]

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 20, 2020
@mhdawson
Copy link
MemberAuthor

mhdawson commented Nov 20, 2020

@MylesBorins is this along the lines of what you had in mind?

@Trott
Copy link
Member

Trott commented Nov 22, 2020

Ironically, the commit message has insufficient context. Maybe this?:

doc: add context for technical values

Trott
Trott reviewed Nov 22, 2020
View reviewed changes
Trott
Trott reviewed Nov 22, 2020
View reviewed changes
@mhdawsonmhdawson mentioned this pull request Nov 23, 2020
Closed
7 tasks
Trott
Trott reviewed Nov 25, 2020
View reviewed changes
Trott
Trott reviewed Nov 25, 2020
View reviewed changes
Trott
Trott reviewed Nov 25, 2020
View reviewed changes
doc/guides/technical-values.md Outdated
Copy link
Member

@TrottTrottNov 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think either "will change" or "will evolve" is sufficient.

Trott
Trott reviewed Nov 25, 2020
View reviewed changes
@jasnell
Copy link
Member

jasnell commented Nov 25, 2020

It would be helpful if the commit log / PR would contain more information about what the additional context is being added to :-)

@mhdawson
doc: provide more context on techinical values
d0a5290
In the discussion of nodejs#35323 it was suggested that we should add some additional context/clarification to the technical values documented for the project. Signed-off-by: Michael Dawson <[email protected]>
@mhdawson
Copy link
MemberAuthor

mhdawson commented Nov 26, 2020

@jasnell updated

@mhdawson
squash: address comments
9a4499c
Signed-off-by: Michael Dawson <[email protected]>
@mhdawson
Copy link
MemberAuthor

mhdawson commented Nov 30, 2020

@MylesBorins if you can take a look would be good to confirm the concern you had.

MylesBorins
MylesBorins approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@MylesBorinsMylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
MemberAuthor

mhdawson commented Dec 2, 2020

@mmarchini any chance you can review/approve since you were in the meeting were we discussed as well?

Trott
Trott reviewed Dec 4, 2020
View reviewed changes
Trott
Trott reviewed Dec 4, 2020
View reviewed changes
@mhdawson
Copy link
MemberAuthor

mhdawson commented Dec 7, 2020

Linters have passed, landing

mhdawson added a commit that referenced this pull request Dec 7, 2020
@mhdawson
doc: provide more context on techinical values
6d3775e
In the discussion of #35323 it was suggested that we should add some additional context/clarification to the technical values documented for the project. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #36201 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@mhdawson
Copy link
MemberAuthor

mhdawson commented Dec 7, 2020

Landed in 6d3775e

@mhdawsonmhdawson closed this Dec 7, 2020
cjihrig pushed a commit to cjihrig/node that referenced this pull request Dec 8, 2020
@mhdawson@cjihrig
doc: provide more context on techinical values
88cd8af
In the discussion of nodejs#35323 it was suggested that we should add some additional context/clarification to the technical values documented for the project. Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#36201 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Dec 21, 2020
@mhdawson@targos
doc: provide more context on techinical values
6a6b3af
In the discussion of #35323 it was suggested that we should add some additional context/clarification to the technical values documented for the project. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #36201 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@targostargos mentioned this pull request Dec 22, 2020
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@mhdawson@targos
doc: provide more context on techinical values
cd06521
In the discussion of #35323 it was suggested that we should add some additional context/clarification to the technical values documented for the project. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #36201 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes

+1 more reviewer

@MylesBorinsMylesBorinsMylesBorins approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mhdawson@Trott@jasnell@MylesBorins@nodejs-github-bot