benchmark : changed fstat to fstatSync#36206
Closed
+1 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added benchmark 
aduh95 approved these changes Nov 21, 2020
lpinca approved these changes Nov 21, 2020
gireeshpunathil approved these changes Nov 23, 2020
2 tasks
Trott approved these changes Nov 24, 2020
github-actionsbot removed the request-ci 
This comment has been minimized.
This comment has been minimized.
Collaborator
jasnell approved these changes Nov 25, 2020
aduh95 added the author ready 
gireeshpunathil added the commit-queue github-actionsbot removed the commit-queue 
Contributor
Landed in 2b21a31...49abda7 |
nodejs-github-bot pushed a commit that referenced this pull request Nov 26, 2020
PR-URL: #36206Fixes: #36199 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
gireeshpunathil commented Nov 26, 2020
thanks @Narasimha1997 for the contribution! 🎉 |
ContributorAuthor
Narasimha1997 commented Nov 26, 2020
@gireeshpunathil , |
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
PR-URL: #36206Fixes: #36199 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
targos pushed a commit that referenced this pull request May 1, 2021
PR-URL: #36206Fixes: #36199 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
fstattofstatSyncas mentioned in the issue #36199Fixes: #36199