test: missed warning for non-experimental AbortController#36240
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jasnell added request-ci 
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Nov 23, 2020
aduh95 approved these changes Nov 23, 2020
Contributor
aduh95 commented Nov 23, 2020
👍 to fast-track |
MemberAuthor
jasnell commented Nov 23, 2020
Just waiting on CI to finish to land. |
codebytere approved these changes Nov 24, 2020
Member
Trott commented Nov 24, 2020
node-core-utils warns about that. If it didn't warn about that, maybe update to the newest version? |
Trott approved these changes Nov 24, 2020
Collaborator
nodejs-github-bot commented Nov 24, 2020
Signed-off-by: James M Snell <[email protected]> PR-URL: nodejs#36240 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Member
Trott commented Nov 24, 2020
Landed in 4388c14 |
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
Signed-off-by: James M Snell <[email protected]> PR-URL: #36240 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test was missed when landing PR (change landed after the CI had run). Should fast-track this.
Signed-off-by: James M Snell [email protected]
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes