fs: move definition from header file#36256
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added c++ 
yashLadha changed the title yashLadhaforce-pushed the fix_duplicate_method_in_fs branch from 6763e17 to 5777b3bCompare
aduh95 approved these changes Nov 25, 2020
aduh95 added author ready 
github-actionsbot removed the request-ci 
This comment has been minimized.
This comment has been minimized.
Collaborator
jasnell approved these changes Nov 25, 2020
lpinca approved these changes Nov 25, 2020
Trott approved these changes Nov 27, 2020
We are defining the definition of function in the header file itself. It should be defined in the source file instead of the header file. PR-URL: nodejs#36256 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Trottforce-pushed the fix_duplicate_method_in_fs branch from 5777b3b to 9bf12dfCompare
Member
Trott commented Nov 29, 2020
Landed in 9bf12df |
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
We are defining the definition of function in the header file itself. It should be defined in the source file instead of the header file. PR-URL: #36256 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
cjihrig pushed a commit to cjihrig/node that referenced this pull request Dec 8, 2020
We are defining the definition of function in the header file itself. It should be defined in the source file instead of the header file. PR-URL: nodejs#36256 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request May 1, 2021
We are defining the definition of function in the header file itself. It should be defined in the source file instead of the header file. PR-URL: #36256 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move definition of method from header file.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes