doc: add table header in intl.md#36261
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MemberAuthor
Trott commented Nov 25, 2020
Before: After: |
joyeecheung approved these changes Nov 25, 2020
aduh95 approved these changes Nov 25, 2020
richardlau approved these changes Nov 25, 2020
jasnell approved these changes Nov 25, 2020
lpinca approved these changes Nov 25, 2020
Trott commented Nov 26, 2020
Uh oh!
There was an error while loading. Please reload this page.
An empty header element in a table is an accessibility issue. In this case, specifying the column as containing a feature seems to be the way to go. PR-URL: nodejs#36261 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MemberAuthor
Trott commented Nov 28, 2020
Landed in 0ac2d0f |
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
An empty header element in a table is an accessibility issue. In this case, specifying the column as containing a feature seems to be the way to go. PR-URL: #36261 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
targos pushed a commit that referenced this pull request May 1, 2021
An empty header element in a table is an accessibility issue. In this case, specifying the column as containing a feature seems to be the way to go. PR-URL: #36261 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An empty header element in a table is an accessibility issue. In this
case, specifying the column as containing a feature seems to be the way
to go.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes