Skip to content

tty: refactor to use more primordials#36272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Trott merged 1 commit into from
Nov 29, 2020
Merged

tty: refactor to use more primordials #36272

Trott merged 1 commit into from
Nov 29, 2020

Conversation

@Lxxyx
Copy link
Member

@LxxyxLxxyx commented Nov 26, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the tty Issues and PRs related to the tty subsystem. label Nov 26, 2020
aduh95
aduh95 approved these changes Nov 26, 2020
View reviewed changes
Copy link
Contributor

@aduh95aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except one nit:

aduh95
aduh95 reviewed Nov 26, 2020
View reviewed changes
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 26, 2020
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 26, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 28, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/34594/

@Lxxyx@Trott
tty: refactor to use more primordials
6ca7312
PR-URL: nodejs#36272 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@Trott
Copy link
Member

Trott commented Nov 29, 2020

Landed in 6ca7312

@TrottTrott merged commit 6ca7312 into nodejs:masterNov 29, 2020
@LxxyxLxxyx deleted the tty-primordials branch November 29, 2020 14:31
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
@Lxxyx@danielleadams
tty: refactor to use more primordials
6bc007f
PR-URL: #36272 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Dec 7, 2020
Merged
cjihrig pushed a commit to cjihrig/node that referenced this pull request Dec 8, 2020
@Lxxyx@cjihrig
tty: refactor to use more primordials
787468c
PR-URL: nodejs#36272 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request May 16, 2021
@Lxxyx@targos
tty: refactor to use more primordials
b641c26
PR-URL: #36272 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@targostargos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@Lxxyx@targos
tty: refactor to use more primordials
41d74a4
PR-URL: #36272 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95aduh95aduh95 approved these changes

@TrottTrottTrott approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.ttyIssues and PRs related to the tty subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Lxxyx@nodejs-github-bot@Trott@aduh95