Skip to content

Conversation

@targos
Copy link
Member

No description provided.

@nodejs-github-botnodejs-github-bot added the build Issues and PRs related to build files or the CI. label Dec 6, 2020
@addaleaxaddaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 6, 2020
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 6, 2020
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@targostargos added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 7, 2020
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 7, 2020
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@richardlaurichardlau mentioned this pull request Dec 10, 2020
3 tasks
Copy link
Member

@mhdawsonmhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

@mhdawson
Copy link
Member

@mhdawson
Copy link
Member

Build good landing

@mhdawson
Copy link
Member

Landed in 7e5bf48

mhdawson pushed a commit that referenced this pull request Dec 11, 2020
PR-URL: #36406 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
@targostargos deleted the allowlist branch December 11, 2020 05:54
targos added a commit that referenced this pull request Dec 21, 2020
PR-URL: #36406 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
@targostargos mentioned this pull request Dec 22, 2020
targos added a commit that referenced this pull request May 1, 2021
PR-URL: #36406 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buildIssues and PRs related to build files or the CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@targos@nodejs-github-bot@mhdawson@Trott@addaleax@lpinca@cjihrig