stream: fix pipe deadlock when starting with needDrain

[ronag]

Related Issues

Fixes: #36544

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[ronag]

Missing test

[HomerSp]

I've updated your test slightly to check for the deadlock: https://gist.github.com/bea83eb0dcbd0aea3b2689c2cd91bb38
Now it will check for the initial pause, which will happen without the fix, and also for end, which won't happen without it. I also set highWaterMark to 1 so it'll happen immediately.

[HomerSp]

Seems like we may need to use common.mustCallAtLeast(1) instead of common.mustCall() because the latter requires it to be called exactly once, and it looks like the build system calls pause twice.

[ronag]

@nodejs/streams

[ronag]

and it looks like the build system calls pause twice.

This was also a separate bug.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/35000/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/35003/

[mcollina]

lgtm

[HomerSp]

and it looks like the build system calls pause twice.

This was also a separate bug.

It's because pause is called when it's finishing (in unpipe) as well as in the pipe call - so your latest test code looks good to me.

[ronag]

Landed in ab895bd