test: fix test-module-loading-error for AlpineLinux#3657
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
bnoordhuis commented Nov 4, 2015
LGTM but please see CONTRIBUTING.md on how to format the commit log. |
hmalphettes changed the title MemberAuthor
hmalphettes commented Nov 9, 2015
@bnoordhuis sorry I had missed the guideline on formatting the commit message. |
Member
jbergstroem commented Nov 10, 2015
I'd replace references regarding AlpineLinux to musl instead since this isn't really specific to Alpine. |
When a compiled library file does not have the proper format, musl returns the error message ENOEXEC as 'Exec format error' but glibc returns 'file too short' if the file is under a certain size. Reference: http://git.musl-libc.org/cgit/musl/tree/src/errno/__strerror.h#n46 This patch consists of tolerating musl's error.
MemberAuthor
hmalphettes commented Nov 10, 2015
@jbergstroem Good point! Done. |
Member
jbergstroem commented Nov 10, 2015
LGTM |
Member
There was a problem hiding this comment.
Bug: platform should be process.platfom here.
MemberAuthor
There was a problem hiding this comment.
Embarrassed! Sorry about that.
bnoordhuis pushed a commit that referenced this pull request Nov 10, 2015
When a compiled library file does not have the proper format, musl returns the error message ENOEXEC as 'Exec format error' but glibc returns 'file too short' if the file is under a certain size. Reference: http://git.musl-libc.org/cgit/musl/tree/src/errno/__strerror.h#n46 This patch consists of tolerating musl's error. PR-URL: #3657 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
Member
bnoordhuis commented Nov 10, 2015
Okay, landed with a fix-up in 1bacf37. The CI is still down unfortunately but tests and lint pass locally. |
Fishrock123 pushed a commit that referenced this pull request Nov 10, 2015
When a compiled library file does not have the proper format, musl returns the error message ENOEXEC as 'Exec format error' but glibc returns 'file too short' if the file is under a certain size. Reference: http://git.musl-libc.org/cgit/musl/tree/src/errno/__strerror.h#n46 This patch consists of tolerating musl's error. PR-URL: #3657 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 17, 2015
When a compiled library file does not have the proper format, musl returns the error message ENOEXEC as 'Exec format error' but glibc returns 'file too short' if the file is under a certain size. Reference: http://git.musl-libc.org/cgit/musl/tree/src/errno/__strerror.h#n46 This patch consists of tolerating musl's error. PR-URL: #3657 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
Contributor
MylesBorins commented Nov 17, 2015
landed in v4.x-staging in 2570cb7 |
rvagg pushed a commit that referenced this pull request Dec 4, 2015
When a compiled library file does not have the proper format, musl returns the error message ENOEXEC as 'Exec format error' but glibc returns 'file too short' if the file is under a certain size. Reference: http://git.musl-libc.org/cgit/musl/tree/src/errno/__strerror.h#n46 This patch consists of tolerating musl's error. PR-URL: #3657 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
Closed
jasnell pushed a commit that referenced this pull request Dec 17, 2015
When a compiled library file does not have the proper format, musl returns the error message ENOEXEC as 'Exec format error' but glibc returns 'file too short' if the file is under a certain size. Reference: http://git.musl-libc.org/cgit/musl/tree/src/errno/__strerror.h#n46 This patch consists of tolerating musl's error. PR-URL: #3657 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
jasnell pushed a commit that referenced this pull request Dec 23, 2015
When a compiled library file does not have the proper format, musl returns the error message ENOEXEC as 'Exec format error' but glibc returns 'file too short' if the file is under a certain size. Reference: http://git.musl-libc.org/cgit/musl/tree/src/errno/__strerror.h#n46 This patch consists of tolerating musl's error. PR-URL: #3657 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node's testsuite fails only 3 cases on AlpineLinux: nodejs/docker-iojs#44 (comment)
Please let us know if it is a good idea to tackle this even if we are not officially supporting a musl-libc build of node.
Here is a patch for one of those tests.
Thanks!