doc: fix the exception description#3658
Uh oh!
There was an error while loading. Please reload this page.
Conversation
A value shouldn't be described as doing inherit from some class, more strictly, the value is an instance of the class `Error`.
Fishrock123 commented Nov 4, 2015
@nodejs/documentation |
Trott commented Nov 4, 2015
I would prefer changing
|
yorkie commented Nov 5, 2015
The
Even thought MDN and wikipedia specify the inheritance is for an object or class, but for future JavaScript usage, the inheritance would look like: classFooextendsBar{ ... }And we cannot do like this: (newFoo)extendsBar;// syntax errorSo, I think to keep the consistence with ES6's syntax, we should change the description to: inheritance should only on classes.
100% agreed on changing from |
yorkie commented Nov 26, 2015
Closing because of inactivity, thank you guys |
Trott commented Nov 26, 2015
If you wish to re-open, the last version you had LGTM. |
yorkie commented Nov 26, 2015
Really? I thought you rejected it :-( |
Trott commented Nov 26, 2015
I had some comments, and you addressed them. I thought it was fine. Sorry I didn't make that clear! Maybe let's see if we can get one more person's opinion? /cc @nodejs/documentation |
yorkie commented Nov 26, 2015
Lol, never mind, REOPEN-ing, thank you :-) |
doc/api/errors.markdown Outdated
There was a problem hiding this comment.
Nit: The scare quotes around exception are unnecessary IMO. Since we're editing nearby text, maybe this is a good opportunity to remove them. Totally optional, feel free to ignore, I'm fine with the change as is.
yorkie commented Nov 26, 2015
@Trott Agreed and fixed :-) |
Trott commented Nov 26, 2015
LGTM. Unless someone else has an objection, I'll land this on Monday UTC. (It's a major holiday in the U.S. today, so I want to give some time for people to chime in, since the issue was dormant for so long. Thanks for your patience!) |
evanlucas commented Nov 26, 2015
LGTM |
Qard commented Nov 26, 2015
LGTM too. 👍 |
cjihrig commented Nov 26, 2015
LGTM |
Trott commented Dec 1, 2015
Landed in 2fb34b6 |
A value shouldn't be described as doing inherit from some class, more strictly, the value is an instance of the class `Error`. PR-URL: #3658 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Stephan Belanger <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
A value shouldn't be described as doing inherit from some class, more strictly, the value is an instance of the class `Error`. PR-URL: #3658 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Stephan Belanger <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
A value shouldn't be described as doing inherit from some class, more strictly, the value is an instance of the class `Error`. PR-URL: #3658 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Stephan Belanger <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
A value shouldn't be described as doing inherit from some class, more strictly, the value is an instance of the class `Error`. PR-URL: #3658 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Stephan Belanger <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
A value shouldn't be described as doing inherit from some class, more strictly, the value is an instance of the class `Error`. PR-URL: #3658 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Stephan Belanger <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
A value shouldn't be described as doing inherit from some class, more strictly, the value is an instance of the class `Error`. PR-URL: nodejs#3658 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Stephan Belanger <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
8 participants
A value shouldn't be described as doing inherit from some class, more
strictly, the value is an instance of the class
Error.Just read the new documentation of Node.js, and raise this up :-)
/cc @chrisdickinson