tools: fix make-v8.sh#36594
Closed
tools: fix make-v8.sh #36594
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
V8's `tools/dev/v8gen.py` does not like being passed an empty string (`""`).
nodejs-github-bot added tools 
MemberAuthor
richardlau commented Dec 21, 2020
Member
targos commented Dec 21, 2020
Can we fast-track? |
targos approved these changes Dec 21, 2020
aduh95 approved these changes Dec 21, 2020
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Dec 21, 2020
cjihrig approved these changes Dec 21, 2020
Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/35028/ ✔️ |
bcoe approved these changes Dec 21, 2020
gengjiawen approved these changes Dec 22, 2020
richardlau added the commit-queue github-actionsbot removed the commit-queue 
Contributor
Landed in 4d22dd3...21f2e88 |
nodejs-github-bot pushed a commit that referenced this pull request Dec 22, 2020
V8's `tools/dev/v8gen.py` does not like being passed an empty string (`""`). PR-URL: #36594 Refs: #36099 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Coe <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
targos pushed a commit that referenced this pull request Dec 22, 2020
V8's `tools/dev/v8gen.py` does not like being passed an empty string (`""`). PR-URL: #36594 Refs: #36099 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Coe <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
targos pushed a commit that referenced this pull request May 1, 2021
V8's `tools/dev/v8gen.py` does not like being passed an empty string (`""`). PR-URL: #36594 Refs: #36099 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Coe <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V8's
tools/dev/v8gen.pydoes not like being passed an empty string(
"").Refs: #36573 (comment)
Refs: #36099
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes