build: fix unknown warning option#36629
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
warning: unknown warning option '-Wno-int-in-bool-context'; did you mean '-Wno-gnu-include-next'? [-Wunknown-warning-option] 1 warning generated. The `-Wint-in-bool-context` diagnostic is not enabled by default, so no additional option is needed.
MemberAuthor
RaisinTen commented Dec 26, 2020
cc @nodejs/build-files |
Trott approved these changes Dec 27, 2020
targos approved these changes Dec 27, 2020
targos added gyp 
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Dec 27, 2020
targos added the commit-queue github-actionsbot removed the commit-queue 
Contributor
Landed in c27efd4...d146b25 |
nodejs-github-bot pushed a commit that referenced this pull request Dec 28, 2020
warning: unknown warning option '-Wno-int-in-bool-context'; did you mean '-Wno-gnu-include-next'? [-Wunknown-warning-option] 1 warning generated. The `-Wint-in-bool-context` diagnostic is not enabled by default, so no additional option is needed. PR-URL: #36629 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
RaisinTen deleted the build/fix-unknown-warning-option-Wno-int-in-bool-context branch danielleadams pushed a commit that referenced this pull request Jan 12, 2021
warning: unknown warning option '-Wno-int-in-bool-context'; did you mean '-Wno-gnu-include-next'? [-Wunknown-warning-option] 1 warning generated. The `-Wint-in-bool-context` diagnostic is not enabled by default, so no additional option is needed. PR-URL: #36629 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
warning: unknown warning option '-Wno-int-in-bool-context';
did you mean '-Wno-gnu-include-next'? [-Wunknown-warning-option]
1 warning generated.
The
-Wint-in-bool-contextdiagnostic is not enabled by default,so no additional option is needed.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes