Skip to content

test: add coverage for breakLength one-column array#36657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Trott merged 0 commits into from
Jan 4, 2021
Merged

test: add coverage for breakLength one-column array #36657

Trott merged 0 commits into from
Jan 4, 2021

Conversation

@Trott
Copy link
Member

@TrottTrott commented Dec 28, 2020

Add coverage for breakLength option resulting in a single-column array
display.

Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/util/inspect.js.html#L1277

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Dec 28, 2020
@TrottTrott changed the title test; add coverage for breakLength one-column arraytest: add coverage for breakLength one-column arrayDec 28, 2020
@TrottTrott requested a review from BridgeARJanuary 1, 2021 13:27
@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 1, 2021
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 1, 2021
@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 3, 2021
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 3, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 3, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/35211/

@Trott
Copy link
MemberAuthor

Trott commented Jan 4, 2021

Landed in f0fc4b8

@TrottTrott closed this Jan 4, 2021
@TrottTrott merged commit f0fc4b8 into nodejs:masterJan 4, 2021
@TrottTrott deleted the cover-me branch January 4, 2021 01:47
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@Trott@danielleadams
test: add coverage for breakLength one-column array
9f7fbcc
Add coverage for breakLength option resulting in a single-column array display. Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/util/inspect.js.html#L1277 PR-URL: #36657 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Jan 12, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Trott@targos
test: add coverage for breakLength one-column array
2896219
Add coverage for breakLength option resulting in a single-column array display. Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/util/inspect.js.html#L1277 PR-URL: #36657 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@BridgeARBridgeARBridgeAR approved these changes

@LxxyxLxxyxLxxyx approved these changes

Assignees

No one assigned

Labels

testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott@nodejs-github-bot@jasnell@BridgeAR@Lxxyx