url: fix url.format with ipv6 hostname#36665
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the url 
lpinca reviewed Dec 28, 2020
Uh oh!
There was an error while loading. Please reload this page.
Lxxyxforce-pushed the fix-url-ipv6-formats branch from bae596a to f766cb0Comparelpinca approved these changes Dec 28, 2020
ronag approved these changes Dec 28, 2020
ronag added request-ci 
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Dec 28, 2020
Trott approved these changes Dec 29, 2020
watilde approved these changes Dec 29, 2020
Contributor
yashLadha left a comment
yashLadha left a comment There was a problem hiding this comment.
Minor changes to use primordials instead of built-in, else changes LGTM.
Uh oh!
There was an error while loading. Please reload this page.
Lxxyxforce-pushed the fix-url-ipv6-formats branch from f766cb0 to 8cbc844CompareLxxyxforce-pushed the fix-url-ipv6-formats branch from 8cbc844 to 244da39Compare
Lxxyxforce-pushed the fix-url-ipv6-formats branch from 244da39 to f9fd2f6Compare
yashLadha approved these changes Dec 30, 2020
yashLadha added the commit-queue github-actionsbot removed the commit-queue 
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/36665 ✔ Done loading data for nodejs/node/pull/36665 ----------------------------------- PR info ------------------------------------ Title url: fix url.format with ipv6 hostname (#36665) Author Lxxyx (@Lxxyx) Branch Lxxyx:fix-url-ipv6-formats -> nodejs:master Labels author ready, url Commits 1 - url: fix url.format with ipv6 hostname Committers 1 - ZiJian Liu PR-URL: https://github.com/nodejs/node/pull/36665 Fixes: https://github.com/nodejs/node/issues/36654 Reviewed-By: Luigi Pinca Reviewed-By: Robert Nagy Reviewed-By: Rich Trott Reviewed-By: Daijiro Wachi Reviewed-By: Yash Ladha ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/36665 Fixes: https://github.com/nodejs/node/issues/36654 Reviewed-By: Luigi Pinca Reviewed-By: Robert Nagy Reviewed-By: Rich Trott Reviewed-By: Daijiro Wachi Reviewed-By: Yash Ladha -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2020-12-28T18:44:50Z: https://ci.nodejs.org/job/node-test-pull-request/35129/ ⚠ Commits were pushed after the last Full PR CI run: ⚠ - url: fix url.format with ipv6 hostname - Querying data for job/node-test-pull-request/35129/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Mon, 28 Dec 2020 15:47:53 GMT ✔ Approvals: 5 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/36665#pullrequestreview-559235401 ✔ - Robert Nagy (@ronag): https://github.com/nodejs/node/pull/36665#pullrequestreview-559254174 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36665#pullrequestreview-559361009 ✔ - Daijiro Wachi (@watilde): https://github.com/nodejs/node/pull/36665#pullrequestreview-559472531 ✔ - Yash Ladha (@yashLadha): https://github.com/nodejs/node/pull/36665#pullrequestreview-559779284 ✖ This PR needs to wait 51 more minutes to land -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/452857792 |
github-actionsbot added the commit-queue-failed yashLadha added commit-queue github-actionsbot removed the commit-queue Contributor
Landed in 37acaf6...1b7ac0c |
nodejs-github-bot pushed a commit that referenced this pull request Dec 30, 2020
Fixes: #36654 PR-URL: #36665 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Yash Ladha <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
Fixes: #36654 PR-URL: #36665 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Yash Ladha <[email protected]>
Merged
targos pushed a commit that referenced this pull request May 1, 2021
Fixes: #36654 PR-URL: #36665 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Yash Ladha <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #36654
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes