Skip to content

fs: accept non-32-bit length in writeBuffer#36667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
RaisinTen wants to merge 1 commit into from
Closed

fs: accept non-32-bit length in writeBuffer #36667

RaisinTen wants to merge 1 commit into from
+2 −2

Conversation

@RaisinTen
Copy link
Member

@RaisinTenRaisinTen commented Dec 28, 2020•
edited
Loading

Since length is size_t, it can accept 64-bit integers too.

Refs: https://man7.org/linux/man-pages/man2/write.2.html
Fixes: #36643

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@RaisinTen
fs: accept non-32-bit length in writeBuffer
8abee23
Since `length` is `size_t`, it can accept 64-bit integers too. Refs: https://man7.org/linux/man-pages/man2/write.2.htmlFixes: nodejs#36643
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. labels Dec 28, 2020
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 29, 2020
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 29, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 29, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/35131/

@Trott
Copy link
Member

Trott commented Dec 29, 2020

Would it be reasonable to add a test?

@targos
Copy link
Member

targos commented Dec 29, 2020

Would it be reasonable to add a test?

I think it's not because it requires to write a file > 2GB to the disk.

@yashLadhayashLadha added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 30, 2020
@github-actionsgithub-actionsbot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 30, 2020
@github-actions
Copy link
Contributor

github-actionsbot commented Dec 30, 2020

Commit Queue failed
- Loading data for nodejs/node/pull/36667 ✔ Done loading data for nodejs/node/pull/36667 ----------------------------------- PR info ------------------------------------ Title fs: accept non-32-bit length in writeBuffer (#36667) Author Darshan Sen (@RaisinTen) Branch RaisinTen:fs/fix-writeBuffer-length-assertion -> nodejs:master Labels author ready, c++, fs Commits 1 - fs: accept non-32-bit length in writeBuffer Committers 1 - raisinten PR-URL: https://github.com/nodejs/node/pull/36667 Fixes: https://github.com/nodejs/node/issues/36643 Refs: https://man7.org/linux/man-pages/man2/write.2.html Reviewed-By: Anna Henningsen Reviewed-By: Antoine du Hamel Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca Reviewed-By: Yash Ladha ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/36667 Fixes: https://github.com/nodejs/node/issues/36643 Refs: https://man7.org/linux/man-pages/man2/write.2.html Reviewed-By: Anna Henningsen Reviewed-By: Antoine du Hamel Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca Reviewed-By: Yash Ladha -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2020-12-29T01:20:36Z: https://ci.nodejs.org/job/node-test-pull-request/35131/ - Querying data for job/node-test-pull-request/35131/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Mon, 28 Dec 2020 16:34:47 GMT ✔ Approvals: 5 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/36667#pullrequestreview-559240760 ✔ - Antoine du Hamel (@aduh95): https://github.com/nodejs/node/pull/36667#pullrequestreview-559345231 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36667#pullrequestreview-559360796 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/36667#pullrequestreview-559670637 ✔ - Yash Ladha (@yashLadha): https://github.com/nodejs/node/pull/36667#pullrequestreview-559756174 ✖ This PR needs to wait 14 more hours to land -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/451875945

@RaisinTenRaisinTen added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Dec 30, 2020
@github-actionsgithub-actionsbot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 30, 2020
@github-actions
Copy link
Contributor

github-actionsbot commented Dec 30, 2020

Landed in 1b7ac0c...c380ee6

nodejs-github-bot pushed a commit that referenced this pull request Dec 30, 2020
@RaisinTen@nodejs-github-bot
fs: accept non-32-bit length in writeBuffer
c380ee6
Since `length` is `size_t`, it can accept 64-bit integers too. Refs: https://man7.org/linux/man-pages/man2/write.2.htmlFixes: #36643 PR-URL: #36667 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yash Ladha <[email protected]> Reviewed-By: Zeyu Yang <[email protected]>
@RaisinTenRaisinTen deleted the fs/fix-writeBuffer-length-assertion branch December 31, 2020 14:49
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@RaisinTen@danielleadams
fs: accept non-32-bit length in writeBuffer
d5e1b82
Since `length` is `size_t`, it can accept 64-bit integers too. Refs: https://man7.org/linux/man-pages/man2/write.2.htmlFixes: #36643 PR-URL: #36667 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yash Ladha <[email protected]> Reviewed-By: Zeyu Yang <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Jan 12, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@RaisinTen@targos
fs: accept non-32-bit length in writeBuffer
fe6e5e4
Since `length` is `size_t`, it can accept 64-bit integers too. Refs: https://man7.org/linux/man-pages/man2/write.2.htmlFixes: #36643 PR-URL: #36667 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yash Ladha <[email protected]> Reviewed-By: Zeyu Yang <[email protected]>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes

@addaleaxaddaleaxaddaleax approved these changes

@lpincalpincalpinca approved these changes

@himself65himself65himself65 approved these changes

@aduh95aduh95aduh95 approved these changes

+1 more reviewer

@yashLadhayashLadhayashLadha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.fsIssues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Node fs package throws: Assertion `args[3]->IsInt32()' failed.

9 participants

@RaisinTen@nodejs-github-bot@Trott@targos@addaleax@lpinca@himself65@aduh95@yashLadha