Skip to content

test: increase coverage for events#36668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Lxxyx wants to merge 1 commit into from
Closed

test: increase coverage for events #36668

Lxxyx wants to merge 1 commit into from

Conversation

@Lxxyx
Copy link
Member

@LxxyxLxxyx commented Dec 28, 2020•
edited
Loading

  1. test EventEmitter.setMaxListeners with invalid listener count
    https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/events.js.html#L171

  2. test EventEmitter.setMaxListeners with invalid emitter
    https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/events.js.html#L186

  3. test getEventListeners with invalid emiiter
    Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/events.js.html#L706

  4. test events.once with options: null
    Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/events.js.html#L712

  5. add test case for inspect new Event()
    Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/event_target.js.html#L111

  6. add test case for insepct new EventTarget()
    Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/event_target.js.html#L446

  7. add test case for Event and EventTarget constructor name

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Dec 28, 2020
Trott
Trott reviewed Dec 29, 2020
View reviewed changes
@LxxyxLxxyxforce-pushed the test-increase-event-coverage branch from b555c75 to ad43af7CompareDecember 29, 2020 04:52
@LxxyxLxxyx requested a review from TrottDecember 29, 2020 05:32
benjamingr
benjamingr reviewed Dec 29, 2020
View reviewed changes
@LxxyxLxxyxforce-pushed the test-increase-event-coverage branch 2 times, most recently from 389b1ed to ecda54fCompareDecember 31, 2020 11:40
@Lxxyx
test: increase coverage for events
0b1e844
1. test EventEmitter.setMaxListeners with invalid listener count https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/events.js.html#L171 2. test EventEmitter.setMaxListeners with invalid emitter https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/events.js.html#L186 3. test getEventListeners with invalid emiiter Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/events.js.html#L706 4. test events.once with options: null Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/events.js.html#L712 5. add test case for inspect new Event() Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/event_target.js.html#L111 6. add test case for insepct new EventTarget() Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/event_target.js.html#L446 7. add test case for Event and EventTarget constructor name
@LxxyxLxxyxforce-pushed the test-increase-event-coverage branch from ecda54f to 0b1e844CompareDecember 31, 2020 11:42
@benjamingrbenjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 31, 2020
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 31, 2020
@benjamingrbenjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 3, 2021
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 3, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 3, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/35208/

@benjamingrbenjamingr added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 3, 2021
@github-actionsgithub-actionsbot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 4, 2021
@github-actions
Copy link
Contributor

github-actionsbot commented Jan 4, 2021

Landed in a19af5e...7c76762

nodejs-github-bot pushed a commit that referenced this pull request Jan 4, 2021
@Lxxyx@nodejs-github-bot
test: increase coverage for events
7c76762
1. test EventEmitter.setMaxListeners with invalid listener count https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/events.js.html#L171 2. test EventEmitter.setMaxListeners with invalid emitter https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/events.js.html#L186 3. test getEventListeners with invalid emiiter Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/events.js.html#L706 4. test events.once with options: null Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/events.js.html#L712 5. add test case for inspect new Event() Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/event_target.js.html#L111 6. add test case for insepct new EventTarget() Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/event_target.js.html#L446 7. add test case for Event and EventTarget constructor name PR-URL: #36668 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@LxxyxLxxyx deleted the test-increase-event-coverage branch January 5, 2021 01:11
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@Lxxyx@danielleadams
test: increase coverage for events
5bc130b
1. test EventEmitter.setMaxListeners with invalid listener count https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/events.js.html#L171 2. test EventEmitter.setMaxListeners with invalid emitter https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/events.js.html#L186 3. test getEventListeners with invalid emiiter Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/events.js.html#L706 4. test events.once with options: null Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/events.js.html#L712 5. add test case for inspect new Event() Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/event_target.js.html#L111 6. add test case for insepct new EventTarget() Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/event_target.js.html#L446 7. add test case for Event and EventTarget constructor name PR-URL: #36668 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Jan 12, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingrbenjamingrbenjamingr approved these changes

@jasnelljasnelljasnell approved these changes

@TrottTrottTrott approved these changes

Assignees

No one assigned

Labels

testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Lxxyx@nodejs-github-bot@jasnell@Trott@benjamingr@targos