Skip to content

domain: make node resilient to Array prototype tempering#36676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aduh95 wants to merge 2 commits into from
Closed

domain: make node resilient to Array prototype tempering #36676

aduh95 wants to merge 2 commits into from

Conversation

@aduh95
Copy link
Contributor

@aduh95aduh95 commented Dec 29, 2020

Fixes: #36669

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the domain Issues and PRs related to the domain subsystem. label Dec 29, 2020
@aduh95aduh95force-pushed the repl-array-prototype-tempering branch from 036d615 to 7068926CompareDecember 29, 2020 15:13
@aduh95aduh95 added the review wanted PRs that need reviews. label Jan 5, 2021
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 9, 2021
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 9, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 9, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/35381/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 9, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/35382/

@jasnell
Copy link
Member

jasnell commented Jan 9, 2021

Landed in 83b428a

@jasnelljasnell closed this Jan 9, 2021
jasnell pushed a commit that referenced this pull request Jan 9, 2021
@aduh95@jasnell
domain: make node resilient to Array prototype tempering
83b428a
Fixes: #36669 PR-URL: #36676 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
@aduh95aduh95 deleted the repl-array-prototype-tempering branch January 9, 2021 22:15
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@aduh95@danielleadams
domain: make node resilient to Array prototype tempering
9b9b6d5
Fixes: #36669 PR-URL: #36676 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Jan 12, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@aduh95@targos
domain: make node resilient to Array prototype tempering
3f43743
Fixes: #36669 PR-URL: #36676 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@TrottTrottTrott approved these changes

@targostargostargos approved these changes

@LxxyxLxxyxLxxyx approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.domainIssues and PRs related to the domain subsystem.review wantedPRs that need reviews.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The Node.js will stuck when exec Object.defineProperty(Array.prototype, '-1',{get: function(){return this[this.length - 1]}}) in REPL

6 participants

@aduh95@nodejs-github-bot@jasnell@Trott@targos@Lxxyx