test: increase buffer list coverage#36688
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
github-actionsbot removed the request-ci 
emilsivervikforce-pushed the test-increase-buffer-list-coverage branch from 0334a00 to 23f7faeCompare
1. test consuming BufferList which has strings with > 1 items Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/streams/buffer_list.js.html#L116 2. test consuming BufferList with > 1 items Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/streams/buffer_list.js.html#L152
emilsivervikforce-pushed the test-increase-buffer-list-coverage branch from 23f7fae to f108d40Compare
Trott approved these changes Jan 12, 2021
Member
Trott commented Jan 12, 2021
Welcome, @emilsivervik, and thanks for the pull request. |
jasnell approved these changes Jan 12, 2021
Collaborator
nodejs-github-bot commented Jan 18, 2021
aduh95 added the author ready 
Member
jasnell commented Jan 18, 2021
Landed in 0aef78e |
jasnell pushed a commit that referenced this pull request Jan 18, 2021
1. test consuming BufferList which has strings with > 1 items Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/streams/buffer_list.js.html#L116 2. test consuming BufferList with > 1 items Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/streams/buffer_list.js.html#L152 PR-URL: #36688 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
1. test consuming BufferList which has strings with > 1 items Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/streams/buffer_list.js.html#L116 2. test consuming BufferList with > 1 items Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/streams/buffer_list.js.html#L152 PR-URL: #36688 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
ruyadorno pushed a commit that referenced this pull request Jan 25, 2021
1. test consuming BufferList which has strings with > 1 items Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/streams/buffer_list.js.html#L116 2. test consuming BufferList with > 1 items Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/streams/buffer_list.js.html#L152 PR-URL: #36688 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request May 1, 2021
1. test consuming BufferList which has strings with > 1 items Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/streams/buffer_list.js.html#L116 2. test consuming BufferList with > 1 items Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/streams/buffer_list.js.html#L152 PR-URL: #36688 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test consuming
BufferListwhich has strings with > 1 itemshttps://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/streams/buffer_list.js.html#L116
test consuming
BufferListwith > 1 itemshttps://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/streams/buffer_list.js.html#L152
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes