docs: Add references in punycode.md#36761
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added doc 
isaacl changed the title 
aduh95 reviewed Jan 3, 2021
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Add references to related `url` functions in punycode.md. These provide guidance to users who may be investigating the punycode module for URL encoding.
ContributorAuthor
isaacl commented Jan 4, 2021
hmm build can't find the links, but they're properly formatted for md. idk |
Contributor
aduh95 commented Jan 4, 2021
We should use the links I provided in my suggestions above, those will work for the CI. |
aduh95 reviewed Jan 4, 2021
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Antoine du Hamel <[email protected]>
aduh95 approved these changes Jan 8, 2021
aduh95 added the author ready 
yashLadha approved these changes Jan 9, 2021
jasnell approved these changes Jan 9, 2021
Member
jasnell commented Jan 9, 2021
Landed in 7dea99b |
jasnell pushed a commit that referenced this pull request Jan 9, 2021
Add references to related `url` functions in punycode.md. These provide guidance to users who may be investigating the punycode module for URL encoding. PR-URL: #36761 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Yash Ladha <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
Add references to related `url` functions in punycode.md. These provide guidance to users who may be investigating the punycode module for URL encoding. PR-URL: #36761 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Yash Ladha <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
targos pushed a commit that referenced this pull request May 1, 2021
Add references to related `url` functions in punycode.md. These provide guidance to users who may be investigating the punycode module for URL encoding. PR-URL: #36761 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Yash Ladha <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add references to related
urlfunctions inpunycode.md. These provideguidance to users who may be investigating the punycode module for URL
encoding.
This is based on confusion I personally experienced reading the deprecation
notice.
Checklist