cluster: remove handles when disconnecting worker#3677
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
cjihrig commented Nov 5, 2015
Looks like the CI had some issues with the test. |
MemberAuthor
bnoordhuis commented Nov 5, 2015
Fix-ups applied. New run: https://ci.nodejs.org/job/node-test-pull-request/675/ |
Contributor
cjihrig commented Nov 5, 2015
LGTM, and I think the CI is ok. Looks like some Windows slaves went offline. |
Contributor
There was a problem hiding this comment.
was going to suggest the same: https://code.google.com/p/v8/issues/detail?id=4518
Member
indutny commented Nov 5, 2015
Commit log is pretty shallow, may I ask you to add more information to it? |
Member
indutny commented Nov 5, 2015
Otherwise LGTM |
Member
jasnell commented Nov 5, 2015
LGTM |
Due to the race window between the master's "disconnect" message and the worker's "handle received" message, connections sometimes got stuck in the pending handles queue when calling `worker.disconnect()` in the master process. The observable effect from the client's perspective was a TCP or HTTP connection that simply stalled. This commit fixes that by closing open handles in the master when the "disconnect" message is sent. Fixes: nodejs#3551 PR-URL: nodejs#3677 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: James M Snell <[email protected]>
MemberAuthor
bnoordhuis commented Nov 6, 2015
Tagged lts-watch-v4.x but can I suggest letting this brew in master / v5 for 10 days or so? |
Member
jasnell commented Nov 6, 2015
+1. Not planning another LTS update round for at least another week
|
bnoordhuis added a commit that referenced this pull request Nov 7, 2015
Due to the race window between the master's "disconnect" message and the worker's "handle received" message, connections sometimes got stuck in the pending handles queue when calling `worker.disconnect()` in the master process. The observable effect from the client's perspective was a TCP or HTTP connection that simply stalled. This commit fixes that by closing open handles in the master when the "disconnect" message is sent. Fixes: #3551 PR-URL: #3677 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: James M Snell <[email protected]>
narqo commented Nov 7, 2015
Any chance this to be ported to v0.12? |
Member
jasnell commented Nov 7, 2015
Possibly. I put it on the watch list so it can be evaluated |
Contributor
MylesBorins commented Nov 17, 2015
@bnoordhuis do you think it is ready to land in v4.x? |
MemberAuthor
bnoordhuis commented Nov 17, 2015
@thealphanerd Maybe wait a little longer, it hasn't made its way into a release yet. It's scheduled for v5.1.0, see #3736 (comment). |
Member
jasnell commented Nov 17, 2015
Yeah, likely best to hold off. Just in case. @bnoordhuis ... keep in mind that @thealphanerd was only talking about landing in |
Contributor
MylesBorins commented Nov 17, 2015
indeed |
MemberAuthor
bnoordhuis commented Nov 17, 2015
Oh, in that case go for it. |
bnoordhuis added a commit that referenced this pull request Nov 30, 2015
Due to the race window between the master's "disconnect" message and the worker's "handle received" message, connections sometimes got stuck in the pending handles queue when calling `worker.disconnect()` in the master process. The observable effect from the client's perspective was a TCP or HTTP connection that simply stalled. This commit fixes that by closing open handles in the master when the "disconnect" message is sent. Fixes: #3551 PR-URL: #3677 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: James M Snell <[email protected]>
bnoordhuis added a commit that referenced this pull request Dec 4, 2015
Due to the race window between the master's "disconnect" message and the worker's "handle received" message, connections sometimes got stuck in the pending handles queue when calling `worker.disconnect()` in the master process. The observable effect from the client's perspective was a TCP or HTTP connection that simply stalled. This commit fixes that by closing open handles in the master when the "disconnect" message is sent. Fixes: #3551 PR-URL: #3677 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: James M Snell <[email protected]>
Closed
bnoordhuis added a commit that referenced this pull request Dec 17, 2015
Due to the race window between the master's "disconnect" message and the worker's "handle received" message, connections sometimes got stuck in the pending handles queue when calling `worker.disconnect()` in the master process. The observable effect from the client's perspective was a TCP or HTTP connection that simply stalled. This commit fixes that by closing open handles in the master when the "disconnect" message is sent. Fixes: #3551 PR-URL: #3677 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: James M Snell <[email protected]>
bnoordhuis added a commit that referenced this pull request Dec 23, 2015
Due to the race window between the master's "disconnect" message and the worker's "handle received" message, connections sometimes got stuck in the pending handles queue when calling `worker.disconnect()` in the master process. The observable effect from the client's perspective was a TCP or HTTP connection that simply stalled. This commit fixes that by closing open handles in the master when the "disconnect" message is sent. Fixes: #3551 PR-URL: #3677 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Mar 29, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #3551
R=@indutny?
CI: https://ci.nodejs.org/job/node-test-pull-request/672/