[v15.x backport] http: refactor to use more primordials#36803
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added lib / src 
Member
targos commented Jan 5, 2021
The commit message should not be changed. |
PR-URL: nodejs#36194 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
aduh95force-pushed the http-primordials-backport branch from 01a1688 to 700023fCompare
Collaborator
nodejs-github-bot commented Jan 12, 2021
Collaborator
nodejs-github-bot commented Jan 12, 2021
danielleadams approved these changes Jan 12, 2021
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
PR-URL: #36194 Backport-PR-URL: #36803 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Contributor
danielleadams commented Jan 12, 2021
Landed in 5e499c4 |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #36194
Reviewed-By: James M Snell [email protected]
Reviewed-By: Rich Trott [email protected]