Skip to content

Conversation

@jasnell
Copy link
Member

Fixes: #35103

@nodejs-github-botnodejs-github-bot added cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. labels Jan 5, 2021
Copy link
Contributor

@MylesBorinsMylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGtm

@jasnelljasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 6, 2021
@jasnelljasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 6, 2021
@jasnell
Copy link
MemberAuthor

This shouldn't need to wait the full time to land. Please 👍🏻 to fast track

@jasnell
Copy link
MemberAuthor

Landed in 9d35b92

@jasnelljasnell closed this Jan 6, 2021
jasnell added a commit that referenced this pull request Jan 6, 2021
Fixes: #35103 PR-URL: #36806 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
Fixes: #35103 PR-URL: #36806 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Jan 12, 2021
targos pushed a commit that referenced this pull request May 1, 2021
Fixes: #35103 PR-URL: #36806 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.cliIssues and PRs related to the Node.js command line interface.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--require doesn't work with import

8 participants

@jasnell@MylesBorins@addaleax@watilde@BethGriggs@aduh95@HarshithaKP@nodejs-github-bot