Skip to content

stream: fix .end() error propagation#36817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ronag wants to merge 4 commits into from
Closed

stream: fix .end() error propagation #36817

ronag wants to merge 4 commits into from

Conversation

@ronag
Copy link
Member

@ronagronag commented Jan 6, 2021

No description provided.

@ronagronag added the stream Issues and PRs related to the stream subsystem. label Jan 6, 2021
@ronagronag requested review from lpinca and mcollinaJanuary 6, 2021 18:46
@ronagronag mentioned this pull request Jan 6, 2021
Closed
@ronagronagforce-pushed the writable-end-error branch from 96a3e8f to db00cc2CompareJanuary 6, 2021 18:47
@ronag
Copy link
MemberAuthor

ronag commented Jan 6, 2021

@nodejs/stream

lpinca
lpinca reviewed Jan 6, 2021
View reviewed changes
@ronagronag requested a review from lpincaJanuary 6, 2021 19:52
lpinca
lpinca reviewed Jan 6, 2021
View reviewed changes
@ronagronagforce-pushed the writable-end-error branch from e25f804 to 48ea4c2CompareJanuary 6, 2021 20:13
@ronagronagforce-pushed the writable-end-error branch from c8eb497 to 5443a22CompareJanuary 6, 2021 20:18
lpinca
lpinca reviewed Jan 6, 2021
View reviewed changes
@ronag
Copy link
MemberAuthor

ronag commented Jan 6, 2021•
edited
Loading

@lpinca: Though I agree that the behavior is a little strange and should be discussed I'm not sure it's relevant for this PR other than we noticed it with the tests added here.

@lpinca
Copy link
Member

lpinca commented Jan 6, 2021•
edited
Loading

I agree, I vaguely remember having already discussed it in an old PR (It was probably the PR calling all pending callbacks on error) but I may be wrong.

lpinca
lpinca approved these changes Jan 6, 2021
View reviewed changes
Copy link
Member

@lpincalpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGMT

mcollina
mcollina approved these changes Jan 6, 2021
View reviewed changes
Copy link
Member

@mcollinamcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronagronag added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jan 6, 2021
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 6, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 6, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/35341/

@ronagronag added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 9, 2021
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 9, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 9, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/35393/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 9, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/35404/

ronag added a commit that referenced this pull request Jan 11, 2021
@ronag
stream: fix .end() error propagation
a4fce32
PR-URL: #36817 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
@ronag
Copy link
MemberAuthor

ronag commented Jan 11, 2021

Landed in a4fce32

@ronagronag closed this Jan 11, 2021
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@ronag@danielleadams
stream: fix .end() error propagation
4c819d6
PR-URL: #36817 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Jan 12, 2021
Merged
@lpincalpinca mentioned this pull request Jan 23, 2021
Closed
@mcollinamcollina added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jan 25, 2021
@mcollina
Copy link
Member

mcollina commented Jan 25, 2021•
edited
Loading

mark this as semver-major post-release as it broke things in v15 :(, see #37027 for more details.

cc @nodejs/tsc

@MrJithilMrJithil mentioned this pull request Jan 26, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes

@lpincalpincalpinca approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.semver-majorPRs that contain breaking changes and should be released in the next major version.streamIssues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ronag@lpinca@nodejs-github-bot@mcollina