Skip to content

Conversation

@othiym23
Copy link
Contributor

(I'll create a separate PR for v4.x-staging.)

This is a rollup release that includes everything since [email protected], so much has changed. See CHANGELOG.md for details. I ran make test-npm against this and everything passed, but it would be good to get confirmation from someone in the release WG.

r: @Fishrock123

@othiym23othiym23 added npm Issues and PRs related to the npm client dependency or the npm registry. land-on-v0.12 labels Nov 6, 2015
This is a roll-up release that includes all changes to npm since 2.13.4.
@othiym23othiym23force-pushed the npm-2.14.9-node-0.12 branch from 7f65c8d to 31571a3CompareNovember 6, 2015 02:57
@othiym23
Copy link
ContributorAuthor

Whitespace fix applied, and force-pushed. Also, reminded myself to read the release process docs more carefully in the future. 🎉

@Fishrock123
Copy link
Contributor

Hmm, patch doesn't like applying for me, same base.

Jeremiahs-MacBook-Pro:node Jeremiah$ curl -L https://github.com/nodejs/node/pull/3684.patch | git am --whitespace=fix % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 138 0 138 0 0 380 0 --:--:-- --:--:-- --:--:-- 380 100 3699k 0 3699k 0 0 973k 0 --:--:-- 0:00:03 --:--:-- 1152k Applying: deps: upgrade npm to 2.14.9 error: deps/npm/test/fixtures/config/userconfig-with-gc: does not match index Patch failed at 0001 deps: upgrade npm to 2.14.9 The copy of the patch that failed is found in: /Users/Jeremiah/documents/node/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". 

@Fishrock123
Copy link
Contributor

Test pass fine. Looks like the diff is too big for me to go though, so rubber-stamp-ish LGTM.

@jasnell
Copy link
Member

LGTM

othiym23 added a commit that referenced this pull request Nov 15, 2015
This is a roll-up release that includes all changes to npm since 2.13.4. PR-URL: #3684 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

Landed in v0.12-staging in ca97fb6

@jasnelljasnell closed this Nov 15, 2015
@rvaggrvagg mentioned this pull request Nov 19, 2015
jBarz pushed a commit to ibmruntimes/node that referenced this pull request Nov 4, 2016
This is a roll-up release that includes all changes to npm since 2.13.4. PR-URL: nodejs/node#3684 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]>
@wraithgarwraithgar deleted the npm-2.14.9-node-0.12 branch June 26, 2025 15:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

npmIssues and PRs related to the npm client dependency or the npm registry.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@othiym23@Fishrock123@jasnell