Skip to content

Conversation

@targos
Copy link
Member

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. http2 Issues or PRs related to the http2 subsystem. labels Jan 8, 2021
@targostargos added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 8, 2021
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 8, 2021
@nodejs-github-bot
Copy link
Collaborator

@targos
Copy link
MemberAuthor

/cc @nodejs/http2

Copy link
Member

@mcollinamcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@TrottTrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

@targostargos added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 10, 2021
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 10, 2021
@nodejs-github-bot
Copy link
Collaborator

targos added a commit that referenced this pull request Jan 11, 2021
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.42.0 PR-URL: #36842 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@targos
Copy link
MemberAuthor

Landed in 6b18987

@targostargos closed this Jan 11, 2021
@targostargos deleted the nghttp2-v1.42.0 branch January 11, 2021 07:15
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.42.0 PR-URL: #36842 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Jan 12, 2021
targos added a commit that referenced this pull request May 1, 2021
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.42.0 PR-URL: #36842 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
codebytere added a commit to electron/electron that referenced this pull request May 14, 2021
codebytere added a commit to electron/electron that referenced this pull request May 18, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buildIssues and PRs related to build files or the CI.http2Issues or PRs related to the http2 subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@targos@nodejs-github-bot@mcollina@Trott@cjihrig@ZYSzys