doc: use ESM syntax for WASI example#36848
Merged
+7 −8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ContributorAuthor
aduh95 commented Jan 12, 2021
@nodejs/wasi |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Contributor
cjihrig commented Jan 13, 2021
Somehow this turned into 101 files being changed? If that's intentional, I think the commits should be split out into separate PRs. |
ContributorAuthor
aduh95 commented Jan 13, 2021
There are two commits, one to add the TLA syntax to the linter, and one to make the change this PR is about. I'm opening #36911 to this PR about WASI docs only. |
cjihrig approved these changes Jan 13, 2021
Contributor
cjihrig left a comment
cjihrig left a comment There was a problem hiding this comment.
The WASI docs change LGTM.
guybedford approved these changes Jan 13, 2021
PR-URL: nodejs#36848 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
ContributorAuthor
aduh95 commented Jan 15, 2021
Landed in 88a5426 |
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
PR-URL: #36848 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
Merged
targos pushed a commit that referenced this pull request May 1, 2021
PR-URL: #36848 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using top-level await and ESM makes sense here I think, and it makes the example easier to follow.