test: mark test-cluster-bind-privileged-port flaky on arm#36850
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jasnell added flaky-test 
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Jan 8, 2021
MemberAuthor
jasnell commented Jan 8, 2021
Please 👍🏻 to fast track so we can unblock CI |
Collaborator
nodejs-github-bot commented Jan 8, 2021
Trott reviewed Jan 8, 2021
Uh oh!
There was an error while loading. Please reload this page.
github-actionsbot removed the request-ci This comment has been minimized.
This comment has been minimized.
Collaborator
nodejs-github-bot commented Jan 8, 2021
Per rvagg: ``` Persistent failure, even after restarts of the whole cluster. nodejs#36478 was merged into this test yesterday but the parent commit still has the failures. What has changed is the Docker version. They all got an upgrade to 5:20.10.2~3-0~raspbian-buster and this is all running inside containers. It's going to be the newest version of Docker running in our CI and I wonder whether we're going to see similar failures when we upgrade other hosts or if this is going to be restricted to ARM. Other than that, I'm not sure what this could be. It seems like a straightforward test that shouldn't fail, maybe Docker has introduced something new for unprivileged port binding inside containers? ``` Signed-off-by: James M Snell <[email protected]>
jasnellforce-pushed the flaky-cluster-bind-privileged-port branch from df3373e to a62b67cComparejasnell added the author ready 
mmarchini approved these changes Jan 8, 2021
MemberAuthor
jasnell commented Jan 8, 2021
Landed in a45a404 |
jasnell added a commit that referenced this pull request Jan 8, 2021
Per rvagg: ``` Persistent failure, even after restarts of the whole cluster. #36478 was merged into this test yesterday but the parent commit still has the failures. What has changed is the Docker version. They all got an upgrade to 5:20.10.2~3-0~raspbian-buster and this is all running inside containers. It's going to be the newest version of Docker running in our CI and I wonder whether we're going to see similar failures when we upgrade other hosts or if this is going to be restricted to ARM. Other than that, I'm not sure what this could be. It seems like a straightforward test that shouldn't fail, maybe Docker has introduced something new for unprivileged port binding inside containers? ``` Signed-off-by: James M Snell <[email protected]> PR-URL: #36850 Refs: #36847 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Mary Marchini <[email protected]>
2 tasks
rvagg added a commit to rvagg/io.js that referenced this pull request Jan 12, 2021
This reverts commit a45a404. Solved by marking ports <1024 as privileged on Docker containers. Ref: nodejs#36850 Ref: nodejs#36847 Ref: nodejs/build#2521
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
Per rvagg: ``` Persistent failure, even after restarts of the whole cluster. #36478 was merged into this test yesterday but the parent commit still has the failures. What has changed is the Docker version. They all got an upgrade to 5:20.10.2~3-0~raspbian-buster and this is all running inside containers. It's going to be the newest version of Docker running in our CI and I wonder whether we're going to see similar failures when we upgrade other hosts or if this is going to be restricted to ARM. Other than that, I'm not sure what this could be. It seems like a straightforward test that shouldn't fail, maybe Docker has introduced something new for unprivileged port binding inside containers? ``` Signed-off-by: James M Snell <[email protected]> PR-URL: #36850 Refs: #36847 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Mary Marchini <[email protected]>
Merged
aduh95 pushed a commit that referenced this pull request Jan 18, 2021
This reverts commit a45a404. Solved by marking ports <1024 as privileged on Docker containers. Ref: #36850 Ref: #36847 Ref: nodejs/build#2521 PR-URL: #36884 Refs: #36850 Refs: #36847 Refs: nodejs/build#2521 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Ash Cripps <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
This reverts commit a45a404. Solved by marking ports <1024 as privileged on Docker containers. Ref: #36850 Ref: #36847 Ref: nodejs/build#2521 PR-URL: #36884 Refs: #36850 Refs: #36847 Refs: nodejs/build#2521 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Ash Cripps <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not clear why the test is suddenly persistently failing only on arm but it's completely blocking being able to land other PRs
Refs: #36847
Per @rvagg:
Signed-off-by: James M Snell [email protected]