doc: update tls test to use better terminology#36851
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Given the effort to change the master branch to main, this may make sense as part of removing other references to the offending wording as well. Signed-off-by: Michael Dawson <[email protected]>
Flarna approved these changes Jan 8, 2021
jasnell approved these changes Jan 8, 2021
Trott approved these changes Jan 9, 2021
mhdawson added request-ci 
Collaborator
nodejs-github-bot commented Jan 14, 2021
Collaborator
nodejs-github-bot commented Jan 14, 2021
MemberAuthor
mhdawson commented Jan 14, 2021
CI failure seems to be known issue: #36868 |
MemberAuthor
mhdawson commented Jan 14, 2021
Resume build: https://ci.nodejs.org/job/node-test-pull-request/35557/ |
mhdawson added a commit that referenced this pull request Jan 14, 2021
Given the effort to change the master branch to main, this may make sense as part of removing other references to the offending wording as well. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #36851 Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MemberAuthor
mhdawson commented Jan 14, 2021
Landed in 00cc39e |
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
Given the effort to change the master branch to main, this may make sense as part of removing other references to the offending wording as well. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #36851 Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
targos pushed a commit that referenced this pull request May 1, 2021
Given the effort to change the master branch to main, this may make sense as part of removing other references to the offending wording as well. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #36851 Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given the effort to change the master branch to main,
this may make sense as part of removing other references
to the offending wording as well.
Signed-off-by: Michael Dawson [email protected]