lib: simplify primordials.uncurryThis#36866
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
addaleax approved these changes Jan 10, 2021
Lxxyx approved these changes Jan 10, 2021
aduh95 approved these changes Jan 10, 2021
aduh95 added author ready 
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Jan 10, 2021
Collaborator
nodejs-github-bot commented Jan 10, 2021
jasnell approved these changes Jan 11, 2021
PoojaDurgad approved these changes Jan 12, 2021
PR-URL: nodejs#36866 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Pooja D P <[email protected]>
aduh95force-pushed the lib/primordials/simplify-uncurry-this branch from 324ea00 to 1a0c5d5Compare
Contributor
aduh95 commented Jan 12, 2021
Landed in 1a0c5d5 |
danielleadams pushed a commit that referenced this pull request Jan 13, 2021
PR-URL: #36866 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Pooja D P <[email protected]>
Merged
targos pushed a commit that referenced this pull request May 25, 2021
PR-URL: #36866 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Pooja D P <[email protected]>
targos pushed a commit that referenced this pull request May 30, 2021
PR-URL: #36866 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Pooja D P <[email protected]>
targos pushed a commit that referenced this pull request Jun 5, 2021
PR-URL: #36866 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Pooja D P <[email protected]>
targos pushed a commit that referenced this pull request Jun 11, 2021
PR-URL: #36866 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Pooja D P <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #36865, it occurred to me that:
is equivalent to:
except that it saves us one indirection through
Function.prototype.call.