doc: fix percentile range in perf_hooks.md#36938
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added doc 
jasnell approved these changes Jan 15, 2021
RaisinTen added the author ready 
aduh95 approved these changes Jan 16, 2021
The value accepted by histogram.percentile may be below 1 too. PR-URL: nodejs#36938 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
aduh95force-pushed the doc/fix-percentile-range-in-perf_hooks.md branch from 563bd54 to b003643Compare
Contributor
aduh95 commented Jan 18, 2021
Landed in b003643 |
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
The value accepted by histogram.percentile may be below 1 too. PR-URL: #36938 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Merged
targos pushed a commit that referenced this pull request May 1, 2021
The value accepted by histogram.percentile may be below 1 too. PR-URL: #36938 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value accepted by
histogram.percentilemay be below 1 too.