Skip to content

test: fixup flaky test-crypto-x509 on windows#36966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aduh95 merged 1 commit into from
Jan 16, 2021
Merged

test: fixup flaky test-crypto-x509 on windows #36966

aduh95 merged 1 commit into from
Jan 16, 2021

Conversation

@jasnell
Copy link
Member

@jasnelljasnell commented Jan 16, 2021•
edited
Loading

image

👍🏻 to fast-track

@jasnelljasnell added flaky-test Issues and PRs related to the tests with unstable failures on the CI. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 16, 2021
@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Jan 16, 2021
@jasnelljasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 16, 2021
@aduh95aduh95 removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 16, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 16, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/35574/

@jasnell@aduh95
test: fixup flaky test-crypto-x509 on windows
433afd9
PR-URL: nodejs#36966 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@aduh95aduh95force-pushed the fix-flaky-x509-test-on-windows branch from 901b0eb to 433afd9CompareJanuary 16, 2021 23:20
@aduh95
Copy link
Contributor

aduh95 commented Jan 16, 2021

Landed in 433afd9

@aduh95aduh95 merged commit 433afd9 into nodejs:masterJan 16, 2021
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
@jasnell@ruyadorno
test: fixup flaky test-crypto-x509 on windows
99c1590
PR-URL: #36966 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@ruyadornoruyadorno mentioned this pull request Jan 22, 2021
Merged
This was referenced Nov 8, 2022
Open
Open
@wedataintelligencewedataintelligence mentioned this pull request Nov 8, 2022
Open
@kissofirekissofire mentioned this pull request Nov 8, 2022
Open
@molllyn1molllyn1 mentioned this pull request Nov 9, 2022
Open
@137717unity137717unity mentioned this pull request Nov 9, 2022
Open
@baby636baby636 mentioned this pull request Nov 9, 2022
Open
@ron-a20ron-a20 mentioned this pull request Nov 9, 2022
Open
@kissofirekissofire mentioned this pull request Mar 18, 2023
Open
@molllyn1molllyn1 mentioned this pull request Jun 8, 2023
Open
This was referenced Jun 8, 2023
Open
Open
@ron-a20ron-a20 mentioned this pull request Jun 8, 2023
Open
@baby636baby636 mentioned this pull request Jun 9, 2023
Open
@137717unity137717unity mentioned this pull request Jun 9, 2023
Open
@wedataintelligencewedataintelligence mentioned this pull request Jun 9, 2023
Open
@ron-a20ron-a20 mentioned this pull request Jun 21, 2023
Open
@137717unity137717unity mentioned this pull request Jun 21, 2023
Open
@wedataintelligencewedataintelligence mentioned this pull request Jun 21, 2023
Open
@baby636baby636 mentioned this pull request Jun 23, 2023
Open
@kissofirekissofire mentioned this pull request Jun 25, 2023
Open
@ron-a20ron-a20 mentioned this pull request Oct 1, 2023
Open
@aliceUnhinged613aliceUnhinged613 mentioned this pull request Oct 1, 2023
Open
@kissofirekissofire mentioned this pull request Oct 1, 2023
Open
@wedataintelligencewedataintelligence mentioned this pull request Oct 2, 2023
Open
@molllyn1molllyn1 mentioned this pull request Oct 2, 2023
Open
@137717unity137717unity mentioned this pull request Oct 2, 2023
Open
@baby636baby636 mentioned this pull request Oct 2, 2023
Open
@wedataintelligencewedataintelligence mentioned this pull request Feb 23, 2024
Open
@kissofirekissofire mentioned this pull request Feb 23, 2024
Open
@molllyn1molllyn1 mentioned this pull request Feb 23, 2024
Open
@baby636baby636 mentioned this pull request Feb 23, 2024
Open
@137717unity137717unity mentioned this pull request Feb 23, 2024
Open
@ron-a20ron-a20 mentioned this pull request Feb 24, 2024
Open
@aliceUnhinged613aliceUnhinged613 mentioned this pull request Feb 24, 2024
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes

@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

fast-trackPRs that do not need to wait for 48 hours to land.flaky-testIssues and PRs related to the tests with unstable failures on the CI.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jasnell@nodejs-github-bot@aduh95@lpinca@targos