deps: update V8 to 4.6.85.31#3698
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
bnoordhuis commented Nov 6, 2015
LGTM |
MemberAuthor
targos commented Nov 6, 2015
Member
JungMinu commented Nov 7, 2015
LGTM |
MemberAuthor
targos commented Nov 10, 2015
New CI because there were a lot of failures on Windows: https://ci.nodejs.org/job/node-test-commit/1071/ |
Contributor
ofrobots commented Nov 10, 2015
LGTM. |
Member
bnoordhuis commented Nov 10, 2015
A flake on one of the Windows buildbots but otherwise green. I'd say it's ready to land. |
This update contains the patch floated in nodejs#3390 and a fix for Intl.NumberFormat. Diff: https://chromium.googlesource.com/v8/v8.git/+/4.6.85.28..4.6.85.31 PR-URL: nodejs#3698 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]>
MemberAuthor
targos commented Nov 11, 2015
landed in 2930867 |
targos added a commit that referenced this pull request Nov 11, 2015
This update contains the patch floated in #3390 and a fix for Intl.NumberFormat. Diff: https://chromium.googlesource.com/v8/v8.git/+/4.6.85.28..4.6.85.31 PR-URL: #3698 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Merged
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update contains the patch floated in
#3390 and a fix for
Intl.NumberFormat.
Diff: https://chromium.googlesource.com/v8/v8.git/+/4.6.85.28..4.6.85.31
cc @nodejs/v8