Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.2k
deps: update ICU to 68.2#36980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
deps: update ICU to 68.2 #36980
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
targos commented Jan 18, 2021
- deps: update ICU to 68.2
- doc: fix maintaining ICU guide
- tools: cleanup old ICU version-specific fixes
Our current minimum ICU is 67, so we don't need to support those anymore
Collaborator
nodejs-github-bot commented Jan 18, 2021
aduh95 approved these changes Jan 18, 2021
richardlau approved these changes Jan 18, 2021
Member
richardlau commented Jan 18, 2021
The dont-land-* labels are due to the |
benjamingr approved these changes Jan 18, 2021
BethGriggs approved these changes Jan 18, 2021
cjihrig approved these changes Jan 18, 2021
targos added a commit that referenced this pull request Jan 20, 2021
Refs: https://github.com/unicode-org/icu/releases/tag/release-68-2 PR-URL: #36980 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos added a commit that referenced this pull request Jan 20, 2021
PR-URL: #36980 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos added a commit that referenced this pull request Jan 20, 2021
Our current minimum ICU is 67, so we don't need to support those anymore PR-URL: #36980 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MemberAuthor
targos commented Jan 20, 2021
Landed in e3e054d...900c9f5 |
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
Refs: https://github.com/unicode-org/icu/releases/tag/release-68-2 PR-URL: #36980 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
PR-URL: #36980 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
Our current minimum ICU is 67, so we don't need to support those anymore PR-URL: #36980 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
ruyadorno pushed a commit that referenced this pull request Jan 25, 2021
Refs: https://github.com/unicode-org/icu/releases/tag/release-68-2 PR-URL: #36980 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
ruyadorno pushed a commit that referenced this pull request Jan 25, 2021
PR-URL: #36980 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
ruyadorno pushed a commit that referenced this pull request Jan 25, 2021
Our current minimum ICU is 67, so we don't need to support those anymore PR-URL: #36980 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos added a commit that referenced this pull request Mar 3, 2021
Refs: https://github.com/unicode-org/icu/releases/tag/release-68-2 PR-URL: #36980 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos added a commit that referenced this pull request Mar 3, 2021
PR-URL: #36980 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos added a commit that referenced this pull request Mar 3, 2021
Our current minimum ICU is 67, so we don't need to support those anymore PR-URL: #36980 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This was referenced Jun 8, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author readyPRs that have at least one approval, no pending requests for changes, and a CI started. toolsIssues and PRs related to the tools directory.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.