benchmark: make output RFC 4180 compliant#37038
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
RaisinTen approved these changes Jan 23, 2021
tniessen added the author ready 
jasnell approved these changes Jan 23, 2021
Trott approved these changes Jan 23, 2021
lpinca approved these changes Jan 23, 2021
aduh95 approved these changes Jan 24, 2021
cjihrig approved these changes Jan 24, 2021
Member
jasnell commented Jan 25, 2021
Just noting for whomever lands this... there don't appear to be any CI tests covering compare.js so a full CI run would be pointless. |
Member
jasnell commented Jan 25, 2021
There's no reason for this to wait the full minimum time to land. Please 👍🏻 to fast-track |
Member
jasnell commented Jan 25, 2021
Landed in 9da3f21 |
jasnell pushed a commit that referenced this pull request Jan 25, 2021
PR-URL: #37038 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
tniessen removed the author ready targos pushed a commit that referenced this pull request Feb 2, 2021
PR-URL: #37038 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request May 1, 2021
PR-URL: #37038 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had trouble importing the generated CSV into other software because it doesn't conform to RFC 4180, the de facto standard for CSV.
Relevant information from the RFC:
Since spaces are considered part of a field, we end up with fields of the form
' "foo"'(note the space in front of the quoted value), and now the quote isn't the first character within the field, so it violates the RFC.