v14.15.5 proposal

[BethGriggs]

2021-02-09, Version 14.15.5 'Fermium' (LTS), @BethGriggs

Notable Changes

• deps:
  • upgrade npm to 6.14.11 (Ruy Adorno) #37173
  • V8: backport dfcf1e86fac0 (Michaël Zasso) #37245
    • Note: Node.js is not believed to be vulnerable to CVE-2021-21148.
• stream,zlib: do not use _stream_* anymore (Matteo Collina) #36618

Commits

• [20b1e6c802] - deps: V8: backport dfcf1e86fac0 (Michaël Zasso) #37245
• [408c7a65f3] - deps: upgrade npm to 6.14.11 (Ruy Adorno) #37173
• [017eed665b] - http: do not loop over prototype in Agent (Michaël Zasso) #36410
• [25a3204fe2] - http: don't cork .end when not needed (Dimitris Halatsis) #36633
• [2a1e4e9244] - stream: accept iterable as a valid first argument (ZiJian Liu) #36479
• [9ff73fcdbe] - stream,zlib: do not use _stream_* anymore (Matteo Collina) #36618
• [c03cddb46f] - test: http complete response after socket double end (Dimitris Halatsis) #36633
• [f206505e9d] - util: fix instanceof checks with null prototypes during inspection (Ruben Bridgewater) #36178
• [2f7944b18b] - util: fix module prefixes during inspection (Ruben Bridgewater) #36178

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/35743/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/3706/ ✅
CITGM(v14.x): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-nobuild/1017/
CITGM(v14.15.5): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2598/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/35748/ ✅

[BethGriggs]

cc: @nodejs/streams as there are a number of streams bug fixes going out in this release.

[BethGriggs]

Delayed by a couple of CITGM reruns. Will update the changelog dates to tomorrow and aim to promote in the morning.

[mcollina]

lgtm

let me know if there is anything in those CITGM I need to take a look for streams.

[BethGriggs]

CITGM is very flaky on both v14.x and v14.15.5 (after several reruns).

┌────────────────────────┬─────────────────────────┬─────────────────┬────────────────────┐ │ (index) │ 0 │ 1 │ 2 │ ├────────────────────────┼─────────────────────────┼─────────────────┼────────────────────┤ │ centos7-ppcle │ 'ember-cli-v3.24.0' │ 'semver-v7.3.4' │ 'socket.io-v3.1.0' │ │ osx1015 │ 'fastify-v3.11.0' │ │ │ │ ubuntu1804-64 │ │ │ │ │ fedora-last-latest-x64 │ 'torrent-stream-v1.2.1' │ │ │ │ rhel7-s390x │ 'torrent-stream-v1.2.1' │ │ │ │ ubuntu1604-64 │ 'winston-v3.3.3' │ │ │ │ win-vs2017 │ 'rewire-v5.0.0' │ │ │ │ fedora-latest-x64 │ │ │ │ │ osx1014 │ │ │ │ └────────────────────────┴─────────────────────────┴─────────────────┴────────────────────┘ 

Summary:

• centos7-ppcle failures are known.
• osx1015 | fastify is a timeout, which I think we've seen before. The osx machines timeout a lot in CITGM too. Passed locally.
• torrent-stream is another familiar flake.
• ubuntu1604-64 | winston flake disappeared on rerun.
• win-vs2017 | rewire - this one seems new but it's not obvious to me whether it's related:

 1) rewire should work like require(): Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (C:\Users\ADMINI~1\AppData\Local\Temp\448829c9-552d-4523-93e0-c42708400ee7\rewire\test\rewire.test.js) at processImmediate (internal/timers.js:461:21) 

Edit: rewire seems okay on no-build reruns on the rc.0 - https://ci.nodejs.org/job/citgm-smoker-nobuild/nodes=win10-vs2019/1021/console

[BethGriggs]

Just doing my final testing before release, and I have just noticed npm is reporting 6.14.10 rather than 6.14.11. I think the deps/npm/package.json bump may have been missed in #36838.

@nodejs/npm / @MylesBorins thoughts on how to proceed? Reland #36838 with the version updated to 6.14.11?

I think v10.23.2 might have gone out yesterday with the content of npm 6.14.11 but reports npm 6.14.10.

[MylesBorins]

@BethGriggs it looks like there may have been something that went awry with the upgrade commit.

npm/cli@ef5b0d3

The release commit definitely bumped the version number, and the published version of the package has the right version. We could delay and get a fixed version of the update commit for you. what do you think?

[BethGriggs]

We could delay and get a fixed version of the update commit for you. what do you think?

@MylesBorins, sure, happy to delay this one to patch up the commit. (Also to be updated on v12.x-staging)

I'm not sure on the best approach for v10.23.2 though

[MylesBorins]

@BethGriggs I think we need to see how big the diff is when we get an updated patch.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/35969/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/36008/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/3742/ ✅

[mcollina]

lgtm

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/36019/ ✅
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/3743/ (2/3 ✅ )
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/3744/ (rerun ✅ )
CITGM(v14.x): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-nobuild/1029/
CITGM(v14.15.5): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2623/

[BethGriggs]

CITGM on v14.15.5 looks okay to me.

Pino is failing on all platforms due to a lint failure, which is being addressed as part of pinojs/pino#961 (cc @mcollina)

[mcollina]

thanks, sorry about this. I'll fix asap.

[BethGriggs]

Release build on 9fff0d3 : https://ci-release.nodejs.org/job/iojs+release/6655